Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Issue 2110113003: Reland of "Move RtcEventLog object from inside VoiceEngine to Call.", "Fix to make the start/stop f… (Closed)

Created:
4 years, 5 months ago by ivoc
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, hlundin-webrtc, yujie_mao (webrtc), zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun, pbos-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of "Move RtcEventLog object from inside VoiceEngine to Call.", "Fix to make the start/stop functions for the Rtc Eventlog non-virtual." and "Fix for RtcEventLog ObjC interface" The breaking tests in Chromium have been temporarily disabled, they will be fixed and reenabled soon. Original CLs: https://codereview.webrtc.org/1748403002/, https://codereview.webrtc.org/2107253002/ and https://codereview.webrtc.org/2106103003/. TBR=solenberg@webrtc.org,tommi@webrtc.org,stefan@webrtc.org,terelius@webrtc.org,tkchin@webrtc.org BUG=webrtc:4741, webrtc:5603, chromium:609749 Committed: https://crrev.com/14d5dbe5b35c560e978dab0c02c48cb16d28273d Cr-Commit-Position: refs/heads/master@{#13379}

Patch Set 1 : Original CL: "Move RtcEventLog object from inside VoiceEngine to Call." #

Patch Set 2 : Original CL: "Fix to make the start/stop functions for the Rtc Eventlog non-virtual." #

Patch Set 3 : Original CL: "Fix for RtcEventLog ObjC interface" #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -357 lines) Patch
M webrtc/api/android/java/src/org/webrtc/PeerConnection.java View 1 2 3 2 chunks +23 lines, -0 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/PeerConnectionFactory.java View 1 2 3 2 chunks +0 lines, -28 lines 0 comments Download
M webrtc/api/peerconnection.h View 2 chunks +11 lines, -0 lines 0 comments Download
M webrtc/api/peerconnection.cc View 3 chunks +22 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectionfactory.h View 1 chunk +8 lines, -5 lines 0 comments Download
M webrtc/api/peerconnectionfactory.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/api/peerconnectionfactoryproxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 1 2 3 2 chunks +24 lines, -15 lines 0 comments Download
M webrtc/api/peerconnectionproxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/audio/DEPS View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/audio/audio_receive_stream.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/audio/audio_receive_stream.cc View 3 chunks +4 lines, -1 line 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 10 chunks +21 lines, -6 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 3 chunks +4 lines, -1 line 0 comments Download
M webrtc/call.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/call/call.cc View 13 chunks +21 lines, -18 lines 0 comments Download
M webrtc/call/rtc_event_log.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/call/rtc_event_log.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M webrtc/examples/objc/AppRTCDemo/ARDAppClient.m View 1 2 3 chunks +13 lines, -12 lines 0 comments Download
M webrtc/media/base/mediaengine.h View 2 chunks +0 lines, -16 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvoiceengine.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc View 6 chunks +13 lines, -2 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/bitrate_controller.h View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc View 5 chunks +10 lines, -17 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 3 chunks +7 lines, -25 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 2 chunks +4 lines, -7 lines 0 comments Download
M webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h View 1 chunk +6 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/pc/channelmanager.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/pc/channelmanager.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm View 1 2 2 chunks +26 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm View 1 2 3 chunks +0 lines, -29 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/test/mock_voe_channel_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/mock_voice_engine.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/channel.h View 4 chunks +5 lines, -4 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 8 chunks +93 lines, -13 lines 0 comments Download
M webrtc/voice_engine/channel_manager.h View 3 chunks +0 lines, -5 lines 0 comments Download
M webrtc/voice_engine/channel_manager.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/voice_engine/include/voe_codec.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/standard/codec_test.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M webrtc/voice_engine/voe_codec_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/voe_codec_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2110113003/40001
4 years, 5 months ago (2016-07-04 11:42:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/builds/14297) android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 5 months ago (2016-07-04 11:44:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2110113003/60001
4 years, 5 months ago (2016-07-04 12:05:12 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-04 14:07:02 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 14:07:10 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/14d5dbe5b35c560e978dab0c02c48cb16d28273d
Cr-Commit-Position: refs/heads/master@{#13379}

Powered by Google App Engine
This is Rietveld 408576698