Reland: Remove global list of SRTP sessions.

Reland: Remove global list of SRTP sessions.

Instead save a reference to the SrtpSession inside the srtp_ctx_t.

The original CL was https://codereview.webrtc.org/1416093010 and
should be good to reland now that internal projects are using a
more recent version of libsrtp.

BUG=webrtc:5133
R=mattdr@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/37bb54eb2079bacc5003eda1b5b69126a9e3e516
Cr-Commit-Position: refs/heads/master@{#13318}

[joachim, 2016-06-28 22:40:13]

Description was changed from

==========
Reland: Remove global list of SRTP sessions.

Instead save a reference to the SrtpSession inside the srtp_ctx_t.

This should be good to reland now that internal projects are using
a more recent version of libsrtp.

BUG=webrtc:5133
==========

to

==========
Reland: Remove global list of SRTP sessions.

Instead save a reference to the SrtpSession inside the srtp_ctx_t.

The original CL was https://codereview.webrtc.org/1416093010 and
should be good to reland now that internal projects are using a
more recent version of libsrtp.

BUG=webrtc:5133
==========

[joachim, 2016-06-28 22:51:02]

jbauch@webrtc.org changed reviewers:
+ mattdr@google.com

[joachim, 2016-06-28 22:51:02]

Thanks for the quick update of your dependencies!

Ptal

[mattdr-at-webrtc.org, 2016-06-28 23:01:39]

mattdr@webrtc.org changed reviewers:
+ mattdr@webrtc.org

[mattdr-at-webrtc.org, 2016-06-28 23:01:39]

https://codereview.webrtc.org/2109893002/diff/20001/webrtc/pc/srtpfilter.cc
File webrtc/pc/srtpfilter.cc (right):

https://codereview.webrtc.org/2109893002/diff/20001/webrtc/pc/srtpfilter.cc#n...
webrtc/pc/srtpfilter.cc:486: session_->user_data = nullptr;
Might it be more appropriate to use srtp_(get|set)_user_data instead of
accessing the context contents directly?

[joachim, 2016-06-28 23:09:01]

https://codereview.webrtc.org/2109893002/diff/20001/webrtc/pc/srtpfilter.cc
File webrtc/pc/srtpfilter.cc (right):

https://codereview.webrtc.org/2109893002/diff/20001/webrtc/pc/srtpfilter.cc#n...
webrtc/pc/srtpfilter.cc:486: session_->user_data = nullptr;
On 2016/06/28 23:01:39, mattdr1 wrote:
> Might it be more appropriate to use srtp_(get|set)_user_data instead of
> accessing the context contents directly?

Done.

[mattdr-at-webrtc.org, 2016-06-28 23:10:48]

lgtm

[joachim, 2016-06-28 23:11:58]

jbauch@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[joachim, 2016-06-28 23:11:59]

+pthatcher for owner review

[pthatcher1, 2016-06-29 00:01:21]

lgtm

[joachim, 2016-06-29 07:18:50]

The CQ bit was checked by jbauch@webrtc.org

[commit-bot: I haz the power, 2016-06-29 07:18:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-06-29 07:40:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 07:40:50]

Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14577)

[joachim, 2016-06-29 08:41:22]

Description was changed from

==========
Reland: Remove global list of SRTP sessions.

Instead save a reference to the SrtpSession inside the srtp_ctx_t.

The original CL was https://codereview.webrtc.org/1416093010 and
should be good to reland now that internal projects are using a
more recent version of libsrtp.

BUG=webrtc:5133
==========

to

==========
Reland: Remove global list of SRTP sessions.

Instead save a reference to the SrtpSession inside the srtp_ctx_t.

The original CL was https://codereview.webrtc.org/1416093010 and
should be good to reland now that internal projects are using a
more recent version of libsrtp.

BUG=webrtc:5133
R=mattdr@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/37bb54eb2079bacc5003eda1b...
==========

[joachim, 2016-06-29 08:41:23]

Committed patchset #3 (id:40001) manually as
37bb54eb2079bacc5003eda1b5b69126a9e3e516 (presubmit successful).

[commit-bot: I haz the power, 2016-06-29 08:41:24]

Description was changed from

==========
Reland: Remove global list of SRTP sessions.

Instead save a reference to the SrtpSession inside the srtp_ctx_t.

The original CL was https://codereview.webrtc.org/1416093010 and
should be good to reland now that internal projects are using a
more recent version of libsrtp.

BUG=webrtc:5133
R=mattdr@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/37bb54eb2079bacc5003eda1b...
==========

to

==========
Reland: Remove global list of SRTP sessions.

Instead save a reference to the SrtpSession inside the srtp_ctx_t.

The original CL was https://codereview.webrtc.org/1416093010 and
should be good to reland now that internal projects are using a
more recent version of libsrtp.

BUG=webrtc:5133
R=mattdr@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/37bb54eb2079bacc5003eda1b5b69126a9e3e516
Cr-Commit-Position: refs/heads/master@{#13318}
==========