Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2109133003: Added empty directory with myself as owner for new mixer. (Closed)

Created:
4 years, 5 months ago by aleloi
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added empty directory with myself as owner for new mixer. NOTRY=True Committed: https://crrev.com/03dd6db5cb7d6552ce84d44b24fa5bfb53fad6ac Cr-Commit-Position: refs/heads/master@{#13345}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed Henrik Lundin's email #

Patch Set 3 : Renamed to avoid compilation crashes and added build file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3205 lines, -29 lines) Patch
M webrtc/modules/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + webrtc/modules/audio_mixer/BUILD.gn View 1 2 2 chunks +31 lines, -10 lines 0 comments Download
M webrtc/modules/audio_mixer/OWNERS View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
A webrtc/modules/audio_mixer/audio_mixer/audio_mixer.h View 1 2 1 chunk +122 lines, -0 lines 0 comments Download
A webrtc/modules/audio_mixer/audio_mixer/audio_mixer.cc View 1 2 1 chunk +450 lines, -0 lines 0 comments Download
A webrtc/modules/audio_mixer/include/audio_conference_mixer.h View 1 2 1 chunk +74 lines, -0 lines 0 comments Download
A webrtc/modules/audio_mixer/include/audio_conference_mixer_defines.h View 1 2 1 chunk +84 lines, -0 lines 0 comments Download
A webrtc/modules/audio_mixer/output_mixer.h View 1 2 1 chunk +123 lines, -0 lines 0 comments Download
A webrtc/modules/audio_mixer/output_mixer.cc View 1 2 1 chunk +450 lines, -0 lines 0 comments Download
A + webrtc/modules/audio_mixer/source/OWNERS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A webrtc/modules/audio_mixer/source/audio_conference_mixer_impl.h View 1 2 1 chunk +188 lines, -0 lines 0 comments Download
A webrtc/modules/audio_mixer/source/audio_conference_mixer_impl.cc View 1 2 1 chunk +895 lines, -0 lines 0 comments Download
A + webrtc/modules/audio_mixer/source/audio_frame_manipulator.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
A webrtc/modules/audio_mixer/source/audio_frame_manipulator.cc View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A webrtc/modules/audio_mixer/source/memory_pool.h View 1 2 1 chunk +108 lines, -0 lines 0 comments Download
A webrtc/modules/audio_mixer/source/memory_pool_posix.h View 1 2 1 chunk +142 lines, -0 lines 0 comments Download
A webrtc/modules/audio_mixer/source/memory_pool_win.h View 1 2 1 chunk +174 lines, -0 lines 0 comments Download
A + webrtc/modules/audio_mixer/source/time_scheduler.h View 1 2 1 chunk +17 lines, -18 lines 0 comments Download
A webrtc/modules/audio_mixer/source/time_scheduler.cc View 1 2 1 chunk +91 lines, -0 lines 0 comments Download
A webrtc/modules/audio_mixer/test/alex_new_fancy_test.cc View 1 2 1 chunk +186 lines, -0 lines 0 comments Download
A + webrtc/modules/audio_mixer/test/audio_conference_mixer_unittest.cc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Dependent Patchsets:

Issue 2105023006 Patch 1

Messages

Total messages: 11 (5 generated)
aleloi
Added tlegrand as top level owner to create new module directory.
4 years, 5 months ago (2016-06-30 09:14:44 UTC) #2
hlundin-webrtc
https://codereview.webrtc.org/2109133003/diff/1/webrtc/modules/audio_mixer/OWNERS File webrtc/modules/audio_mixer/OWNERS (right): https://codereview.webrtc.org/2109133003/diff/1/webrtc/modules/audio_mixer/OWNERS#newcode2 webrtc/modules/audio_mixer/OWNERS:2: hlundin@webrtc.org I am not hlundin@webrtc.org, it should be henrik.lundin@webrtc.org.
4 years, 5 months ago (2016-06-30 10:03:54 UTC) #3
tlegrand-webrtc
On 2016/06/30 10:03:54, hlundin-webrtc wrote: > https://codereview.webrtc.org/2109133003/diff/1/webrtc/modules/audio_mixer/OWNERS > File webrtc/modules/audio_mixer/OWNERS (right): > > https://codereview.webrtc.org/2109133003/diff/1/webrtc/modules/audio_mixer/OWNERS#newcode2 > ...
4 years, 5 months ago (2016-06-30 11:56:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2109133003/20001
4 years, 5 months ago (2016-06-30 11:57:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 12:03:16 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 12:03:26 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/03dd6db5cb7d6552ce84d44b24fa5bfb53fad6ac
Cr-Commit-Position: refs/heads/master@{#13345}

Powered by Google App Engine
This is Rietveld 408576698