Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2109103002: Enhance portable NTLM implementation to support NTLMv2. (Closed)

Created:
4 years, 5 months ago by Basu
Modified:
3 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, lgombos, cbentzel, asanka, Randy Smith (Not in Mondays)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enhance portable NTLM implementation to support NTLMv2. Chromium currently supports NTLMv1, this patch adds support for NTLMv2. This patch is based on Mozilla Firefox's NTLMv2 support https://hg.mozilla.org/mozilla-central/rev/f09bfc814171 BUG=22532

Patch Set 1 #

Patch Set 2 : Moved hmac_md5 from base/md5 to net/http/md5 #

Total comments: 4

Patch Set 3 : Addresses Mark's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -75 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_auth_handler_ntlm_portable.cc View 1 2 18 chunks +238 lines, -75 lines 0 comments Download
A net/http/md5.h View 1 1 chunk +20 lines, -0 lines 0 comments Download
A net/http/md5.cc View 1 1 chunk +104 lines, -0 lines 0 comments Download
M net/net.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/copyright_scanner/third_party_files_whitelist.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (13 generated)
Basu
Please take a look at the patch Thanks
4 years, 5 months ago (2016-06-29 09:53:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109103002/1
4 years, 5 months ago (2016-06-29 12:46:26 UTC) #4
commit-bot: I haz the power
Dry run: The author basavaraj.ps@samsung.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com ...
4 years, 5 months ago (2016-06-29 12:46:29 UTC) #6
Ryan Sleevi
Please indicate when you've signed the CLA. I'm not sure how best to discuss provenance ...
4 years, 5 months ago (2016-06-29 16:39:25 UTC) #11
Randy Smith (Not in Mondays)
I don't think I'm the right person to review this patch, as I know close ...
4 years, 5 months ago (2016-06-30 01:45:25 UTC) #14
Basu
Hi Ryan, thanks for having a look at this patch. On 2016/06/29 16:39:25, Ryan Sleevi ...
4 years, 5 months ago (2016-06-30 06:09:47 UTC) #15
Ryan Sleevi
On 2016/06/30 06:09:47, Basu wrote: > This patch is ported from Firefox codebase [3], and ...
4 years, 5 months ago (2016-07-01 00:05:30 UTC) #16
Basu
On 2016/07/01 00:05:30, Ryan Sleevi wrote: > On 2016/06/30 06:09:47, Basu wrote: > > This ...
4 years, 5 months ago (2016-07-01 10:31:20 UTC) #17
Basu
On 2016/07/01 00:05:30, Ryan Sleevi (slow) wrote: > On 2016/06/30 06:09:47, Basu wrote: > > ...
4 years, 4 months ago (2016-08-08 07:36:45 UTC) #18
Mark Larson
We don't need to change the MPL 1.1 block from the original checkin, but we ...
4 years, 3 months ago (2016-09-01 19:00:52 UTC) #21
Basu
On 2016/09/01 19:00:52, Mark Larson wrote: > We don't need to change the MPL 1.1 ...
4 years, 3 months ago (2016-09-02 06:24:25 UTC) #22
Basu
Thanks Mark for review. New patch set incorporates comments. Thanks! https://codereview.chromium.org/2109103002/diff/20001/net/http/http_auth_handler_ntlm_portable.cc File net/http/http_auth_handler_ntlm_portable.cc (right): https://codereview.chromium.org/2109103002/diff/20001/net/http/http_auth_handler_ntlm_portable.cc#newcode37 ...
4 years, 3 months ago (2016-09-02 06:26:35 UTC) #23
Basu
On 2016/09/02 06:26:35, Basu wrote: > Thanks Mark for review. > New patch set incorporates ...
3 years, 6 months ago (2017-05-26 06:42:19 UTC) #26
chromium-reviews
A new implementation is already in progress including the features missing from the firefox implementation ...
3 years, 6 months ago (2017-05-26 14:53:14 UTC) #27
asanka
3 years, 5 months ago (2017-06-23 15:51:18 UTC) #28
Message was sent while issue was closed.
Thanks for the patch! I've closed the issue since we are not going to move
forward with accepting this patch.

There's a comprehensive NTLMv2 implementation that is current in progress.

Powered by Google App Engine
This is Rietveld 408576698