Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2108493003: Fixing P2PTransportChannelTest.TestIceConfigWillPassDownToPort. (Closed)

Created:
4 years, 5 months ago by Taylor Brandstetter
Modified:
4 years, 5 months ago
Reviewers:
pthatcher1, honghaiz3
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing P2PTransportChannelTest.TestIceConfigWillPassDownToPort. Was flaky because it was checking the role of a port, but a role conflict could occur before this happened which would swap the role. BUG=webrtc:6019 R=honghaiz@webrtc.org, pthatcher@webrtc.org TBR=honghaiz@webrtc.org Committed: https://crrev.com/f3d8d32c5f87a3a3a01bcd77809041daff9ba48d Cr-Commit-Position: refs/heads/master@{#13327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 4 chunks +13 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Taylor Brandstetter
4 years, 5 months ago (2016-06-28 02:09:30 UTC) #2
pthatcher1
lgtm
4 years, 5 months ago (2016-06-28 20:14:10 UTC) #3
honghaiz3
lgtm
4 years, 5 months ago (2016-06-29 17:50:20 UTC) #5
Taylor Brandstetter
4 years, 5 months ago (2016-06-29 18:07:52 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f3d8d32c5f87a3a3a01bcd77809041daff9ba48d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698