Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1776)

Issue 2107303003: Adding API for "presume writable when fully relayed" ICE option. (Closed)

Created:
4 years, 5 months ago by Taylor Brandstetter
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merging with master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M webrtc/api/android/java/src/org/webrtc/PeerConnection.java View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/api/android/jni/peerconnection_jni.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/webrtcsession.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm View 4 chunks +8 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Taylor Brandstetter
4 years, 5 months ago (2016-06-29 22:49:36 UTC) #2
AlexG
lgtm
4 years, 5 months ago (2016-06-30 04:52:01 UTC) #3
pthatcher1
lgtm
4 years, 5 months ago (2016-06-30 20:39:41 UTC) #4
Taylor Brandstetter
I'm going to land this now and let Zeke review later, since it's pretty straightforward.
4 years, 5 months ago (2016-06-30 21:26:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2107303003/1
4 years, 5 months ago (2016-06-30 21:26:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14712)
4 years, 5 months ago (2016-06-30 21:34:02 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e9851116e275c1eadf51031066561d42a1e984db Cr-Commit-Position: refs/heads/master@{#13366}
4 years, 5 months ago (2016-07-01 18:11:27 UTC) #13
Taylor Brandstetter
4 years, 5 months ago (2016-07-01 18:11:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e9851116e275c1eadf51031066561d42a1e984db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698