Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2106863002: Constructor in Camera1Enumerator should be public. (Closed)

Created:
4 years, 5 months ago by sakal
Modified:
4 years, 5 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Constructor in Camera1Enumerator should be public. R=danilchap@webrtc.org TBR=magjed_webrtc Committed: https://crrev.com/9c7a0dbc8a5f6816ca1498a0fea48fa559ec44da Cr-Commit-Position: refs/heads/master@{#13315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/api/java/android/org/webrtc/Camera1Enumerator.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
danilchap
lgtm
4 years, 5 months ago (2016-06-28 16:58:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2106863002/1
4 years, 5 months ago (2016-06-28 16:58:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/9083) android_dbg on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 5 months ago (2016-06-28 17:01:59 UTC) #7
sakal
4 years, 5 months ago (2016-06-28 17:04:12 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9c7a0dbc8a5f6816ca1498a0fea48fa559ec44da (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698