Fix bug where min transmit bitrate wasn't working

webrtc/video/video_send_stream.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 570 matching lines @@
         pending_encoder_settings_.reset();
         change_settings = true;
       } else if (pending_state_change_) {
         swap(pending_state_change, pending_state_change_);
       }
     }
     if (change_settings) {
       current_encoder_settings_->video_codec.startBitrate = std::max(
           bitrate_allocator_->GetStartBitrate(this) / 1000,
           static_cast<int>(current_encoder_settings_->video_codec.minBitrate));
+
+      bitrate_allocator_->AddObserver(

[perkj_webrtc, 2016/07/04 07:24:49]

We should not add as observer unless the stream i started.
i.e if (state_ == kStarted) ... bitrate_allocator->...

[sprang_webrtc, 2016/07/04 09:08:47]

Done.

+          this, current_encoder_settings_->video_codec.minBitrate * 1000,
+          current_encoder_settings_->video_codec.maxBitrate * 1000,
+          CalulcateMaxPadBitrateBps(current_encoder_settings_->config,
+                                    config_.suspend_below_min_bitrate),
+          !config_.suspend_below_min_bitrate);
+
       payload_router_.SetSendStreams(current_encoder_settings_->config.streams);
       vie_encoder_.SetEncoder(current_encoder_settings_->video_codec,
                               payload_router_.MaxPayloadLength());
 
       // Clear stats for disabled layers.
       for (size_t i = current_encoder_settings_->config.streams.size();
            i < config_.rtp.ssrcs.size(); ++i) {
         stats_proxy_.OnInactiveSsrc(config_.rtp.ssrcs[i]);
       }
 
@@ skipping 294 matching lines @@
                           &module_nack_rate);
     *sent_video_rate_bps += module_video_rate;
     *sent_nack_rate_bps += module_nack_rate;
     *sent_fec_rate_bps += module_fec_rate;
   }
   return 0;
 }
 
 }  // namespace internal
 }  // namespace webrtc