Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2106103003: Fix for RtcEventLog ObjC interface (Closed)

Created:
4 years, 5 months ago by ivoc
Modified:
4 years, 5 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix for RtcEventLog ObjC interface This moves the RtcEventLog start/stop functions to PeerConnection on the objC interface. BUG= R=tkchin@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c43bf56ef1e3f91bbbf936ed4aca6916bb4f081c

Patch Set 1 #

Patch Set 2 : Fix for some misedits. #

Total comments: 4

Patch Set 3 : Fixed formatting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -46 lines) Patch
M webrtc/examples/objc/AppRTCDemo/ARDAppClient.m View 1 3 chunks +13 lines, -12 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm View 1 2 2 chunks +26 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm View 1 3 chunks +0 lines, -29 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
ivoc
Hi Zeke, Please take a look at this small CL to fix the objC interface.
4 years, 5 months ago (2016-06-29 21:11:53 UTC) #3
tkchin_webrtc
lgtm https://codereview.webrtc.org/2106103003/diff/20001/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm File webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm (right): https://codereview.webrtc.org/2106103003/diff/20001/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm#newcode360 webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm:360: - (BOOL)startRtcEventLogWithFilePath:(NSString*)filePath NSString *) https://codereview.webrtc.org/2106103003/diff/20001/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h (right): ...
4 years, 5 months ago (2016-06-29 23:02:08 UTC) #4
ivoc
https://codereview.webrtc.org/2106103003/diff/20001/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm File webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm (right): https://codereview.webrtc.org/2106103003/diff/20001/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm#newcode360 webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm:360: - (BOOL)startRtcEventLogWithFilePath:(NSString*)filePath On 2016/06/29 23:02:08, tkchin_webrtc wrote: > NSString ...
4 years, 5 months ago (2016-06-30 06:56:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2106103003/40001
4 years, 5 months ago (2016-06-30 06:57:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14662)
4 years, 5 months ago (2016-06-30 07:03:26 UTC) #10
ivoc
Committed patchset #3 (id:40001) manually as c43bf56ef1e3f91bbbf936ed4aca6916bb4f081c (presubmit successful).
4 years, 5 months ago (2016-06-30 07:32:21 UTC) #13
ivoc
4 years, 5 months ago (2016-06-30 07:54:45 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2110373002/ by ivoc@webrtc.org.

The reason for reverting is: Reverting all CLs related to moving the eventlog,
as they break Chromium tests..

Powered by Google App Engine
This is Rietveld 408576698