Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2105813002: Add override annotation to appropriate methods in Camera1Enumerator. (Closed)

Created:
4 years, 5 months ago by sakal
Modified:
4 years, 5 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add override annotation to appropriate methods in Camera1Enumerator. Also move getDeviceNames to a more appropriate location in the file. NOTRY=True Committed: https://crrev.com/70fae2ccc6e65967affdce1ebe324c95c207b650 Cr-Commit-Position: refs/heads/master@{#13312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M webrtc/api/java/android/org/webrtc/Camera1Enumerator.java View 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sakal
Magnus, please take a look.
4 years, 5 months ago (2016-06-28 15:09:09 UTC) #5
magjed_webrtc
lgtm
4 years, 5 months ago (2016-06-28 15:34:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2105813002/20001
4 years, 5 months ago (2016-06-28 15:35:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-06-28 15:36:41 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 15:36:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70fae2ccc6e65967affdce1ebe324c95c207b650
Cr-Commit-Position: refs/heads/master@{#13312}

Powered by Google App Engine
This is Rietveld 408576698