Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2105803002: Add GN targets for AppRTC Demo on Android. (Closed)

Created:
4 years, 5 months ago by sakal
Modified:
4 years, 5 months ago
Reviewers:
magjed_webrtc, tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add GN targets for AppRTC Demo on Android. Adds GN equivalents for following targets: AppRTCDemo -> //webrtc/examples:AppRTCDemo AppRTCDemo_apk -> //webrtc/examples:AppRTCDemo_lib (kind of) AppRTCDemoJUnitTest -> //webrtc/examples:AppRTCDemoJUnitTest AppRTCDemoTest -> //webrtc/examples:AppRTCDemoTest libjingle_peerconnection_java -> //webrtc/api/libjingle_peerconnection_java libjingle_peerconnection_so -> //webrtc/api/libjingle_peerconnection_so New GN targets: //webrtc/base:base_java //webrtc/examples:AppRTCDemo_resources //webrtc/examples/androidapp/third_party/autobanh:autobanh_java BUG=webrtc:6035 R=magjed@webrtc.org, tommi@webrtc.org Committed: https://crrev.com/9c0c75bd6edf80d7a2edd6028ac6b96393d063a7 Cr-Commit-Position: refs/heads/master@{#13322}

Patch Set 1 #

Patch Set 2 : Unrename targets. #

Patch Set 3 : Sort the files and don't rename targets. #

Total comments: 2

Patch Set 4 : Move autobanh back inside androidapp, move webrtc/examples dependency to root. #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -8 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/BUILD.gn View 1 2 3 4 2 chunks +77 lines, -0 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 2 3 4 2 chunks +19 lines, -0 lines 0 comments Download
A webrtc/examples/BUILD.gn View 1 2 3 1 chunk +103 lines, -0 lines 0 comments Download
A + webrtc/examples/androidapp/third_party/autobanh/BUILD.gn View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
D webrtc/examples/androidapp/third_party/autobanh/autobanh.jar View Binary file 0 comments Download
A + webrtc/examples/androidapp/third_party/autobanh/lib/autobanh.jar View 1 2 3 Binary file 0 comments Download
M webrtc/webrtc_examples.gyp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
sakal
Magnus, please take a look.
4 years, 5 months ago (2016-06-28 14:50:31 UTC) #5
magjed_webrtc
I think you should move autobahn back under the examples folder. https://codereview.webrtc.org/2105803002/diff/40001/webrtc/BUILD.gn File webrtc/BUILD.gn (right): ...
4 years, 5 months ago (2016-06-28 15:48:16 UTC) #6
sakal
https://codereview.webrtc.org/2105803002/diff/40001/webrtc/BUILD.gn File webrtc/BUILD.gn (right): https://codereview.webrtc.org/2105803002/diff/40001/webrtc/BUILD.gn#newcode257 webrtc/BUILD.gn:257: "examples", On 2016/06/28 15:48:16, magjed_webrtc wrote: > I think ...
4 years, 5 months ago (2016-06-29 08:15:58 UTC) #8
magjed_webrtc
lgtm
4 years, 5 months ago (2016-06-29 08:28:55 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2105803002/60001
4 years, 5 months ago (2016-06-29 08:39:15 UTC) #11
sakal
Tommi, please take a look.
4 years, 5 months ago (2016-06-29 08:40:47 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14582)
4 years, 5 months ago (2016-06-29 08:47:09 UTC) #15
tommi
lgtm
4 years, 5 months ago (2016-06-29 11:29:52 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2105803002/110001
4 years, 5 months ago (2016-06-29 11:50:36 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14601)
4 years, 5 months ago (2016-06-29 12:00:47 UTC) #22
sakal
Committed patchset #5 (id:110001) manually as 9c0c75bd6edf80d7a2edd6028ac6b96393d063a7 (presubmit successful).
4 years, 5 months ago (2016-06-29 12:55:19 UTC) #25
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 12:55:20 UTC) #26
Patchset 5 (id:??) landed as
https://crrev.com/9c0c75bd6edf80d7a2edd6028ac6b96393d063a7
Cr-Commit-Position: refs/heads/master@{#13322}

Powered by Google App Engine
This is Rietveld 408576698