Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2105163003: [MERGE TO M52] Don't recreate the speech encoder if we don't have to (Closed)

Created:
4 years, 5 months ago by hlundin-webrtc
Modified:
4 years, 5 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@52
Target Ref:
refs/pending/branch-heads/52
Project:
webrtc
Visibility:
Public.

Description

[MERGE TO M52] Don't recreate the speech encoder if we don't have to If the specification for the speech encoder hasn't changed, we should reuse it instead of recreating it. Otherwise, we lose its state. (This problem was originally discovered because AudioEncoderOpus instances would forget that they were supposed to be using DTX.) BUG=webrtc:6020, chromium:622647 Review-Url: https://codereview.webrtc.org/2089183002 Cr-Commit-Position: refs/heads/master@{#13273} (cherry picked from commit 3f81fcd2e845505c2873c7ec2edade910213596b) Committed: https://chromium.googlesource.com/external/webrtc/+/15a5d9f9e3e4e8591c7a598c3818f42987cff522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -21 lines) Patch
M webrtc/base/array_view.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/codec_manager.h View 1 chunk +2 lines, -20 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/codec_manager.cc View 2 chunks +63 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.h View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hlundin-webrtc
4 years, 5 months ago (2016-06-29 08:27:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
15a5d9f9e3e4e8591c7a598c3818f42987cff522.

Powered by Google App Engine
This is Rietveld 408576698