Fixing race condition in IncomingVideoStream.

Fixing race condition in IncomingVideoStream.

This really only happens on the memcheck bot. But the issue is that
the render thread may be started before the timer is started on
the main thread, which incorrectly attaches the timer to the render
thread. Then a thread check assertion occurs when the timer is
stopped on the main thread.

Simply starting the timer before starting the render thread fixes this.

BUG=webrtc:6062
TBR=tommi@webrtc.org

Committed: https://crrev.com/65f47275cbb5ad3aa5146b9e75afa9894467daff
Cr-Commit-Position: refs/heads/master@{#13317}

[Taylor Brandstetter, 2016-06-28 17:09:03]

deadbeef@webrtc.org changed reviewers:
+ tommi@webrtc.org

[Taylor Brandstetter, 2016-06-28 17:09:19]

Description was changed from

==========
Fixing race condition in IncomingVideoStream.

This really only happens on the memcheck bot. But the issue is that
the render thread may be started before the timer is started on
the main thread, which incorrectly attaches the timer to the render
thread. Then a thread check assertion occurs when the timer is
stopped on the main thread.

Simply starting the timer before starting the render thread fixes this.

BUG=webrtc:6062
==========

to

==========
Fixing race condition in IncomingVideoStream.

This really only happens on the memcheck bot. But the issue is that
the render thread may be started before the timer is started on
the main thread, which incorrectly attaches the timer to the render
thread. Then a thread check assertion occurs when the timer is
stopped on the main thread.

Simply starting the timer before starting the render thread fixes this.

BUG=webrtc:6062
TBR=tommi@webrtc.org
==========

[Taylor Brandstetter, 2016-06-28 17:09:43]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-06-28 17:09:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-06-28 17:14:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 17:14:21]

Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14567)

[Taylor Brandstetter, 2016-06-28 17:46:49]

Description was changed from

==========
Fixing race condition in IncomingVideoStream.

This really only happens on the memcheck bot. But the issue is that
the render thread may be started before the timer is started on
the main thread, which incorrectly attaches the timer to the render
thread. Then a thread check assertion occurs when the timer is
stopped on the main thread.

Simply starting the timer before starting the render thread fixes this.

BUG=webrtc:6062
TBR=tommi@webrtc.org
==========

to

==========
Fixing race condition in IncomingVideoStream.

This really only happens on the memcheck bot. But the issue is that
the render thread may be started before the timer is started on
the main thread, which incorrectly attaches the timer to the render
thread. Then a thread check assertion occurs when the timer is
stopped on the main thread.

Simply starting the timer before starting the render thread fixes this.

BUG=webrtc:6062
TBR=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/65f47275cbb5ad3aa5146b9e7...
==========

[Taylor Brandstetter, 2016-06-28 17:46:50]

Committed patchset #1 (id:1) manually as
65f47275cbb5ad3aa5146b9e75afa9894467daff (presubmit successful).

[commit-bot: I haz the power, 2016-06-28 17:46:51]

Description was changed from

==========
Fixing race condition in IncomingVideoStream.

This really only happens on the memcheck bot. But the issue is that
the render thread may be started before the timer is started on
the main thread, which incorrectly attaches the timer to the render
thread. Then a thread check assertion occurs when the timer is
stopped on the main thread.

Simply starting the timer before starting the render thread fixes this.

BUG=webrtc:6062
TBR=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/65f47275cbb5ad3aa5146b9e7...
==========

to

==========
Fixing race condition in IncomingVideoStream.

This really only happens on the memcheck bot. But the issue is that
the render thread may be started before the timer is started on
the main thread, which incorrectly attaches the timer to the render
thread. Then a thread check assertion occurs when the timer is
stopped on the main thread.

Simply starting the timer before starting the render thread fixes this.

BUG=webrtc:6062
TBR=tommi@webrtc.org

Committed: https://crrev.com/65f47275cbb5ad3aa5146b9e75afa9894467daff
Cr-Commit-Position: refs/heads/master@{#13317}
==========

[tommi, 2016-06-28 17:49:54]

Thanks! Lgtm