Work around /analyze internal compiler error

base/time/time.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Time represents an absolute point in coordinated universal time (UTC),
 // internally represented as microseconds (s/1,000,000) since the Windows epoch
 // (1601-01-01 00:00:00 UTC). System-dependent clock interface routines are
 // defined in time_PLATFORM.cc. Note that values for Time may skew and jump
 // around as the operating system makes adjustments to synchronize (e.g., with
 // NTP servers). Thus, client code that uses the Time class must account for
@@ skipping 649 matching lines @@
   return value > std::numeric_limits<int64_t>::max()
              ? Max()
              : value < -std::numeric_limits<int64_t>::max()
                    ? -Max()
                    : TimeDelta(static_cast<int64_t>(value));
 }
 
 // static
 constexpr TimeDelta TimeDelta::FromProduct(int64_t value,
                                            int64_t positive_value) {
-  return (DCHECK(positive_value > 0),
+  return (
+#if !defined(_PREFAST_) || !defined(OS_WIN)

[dcheng, 2016/06/29 08:07:48]

Are there non-Windows builds that define _PREFAST_? I figured that _PREFAST_
would imply Windows.

[brucedawson, 2016/06/29 17:47:18]

I check OS_WIN for consistency with other places that we check _PREFAST_.

+          // Avoid internal compiler errors in /analyze builds with VS 2015
+          // update 3.
+          // https://connect.microsoft.com/VisualStudio/feedback/details/2870865
+          DCHECK(positive_value > 0),
+#endif
           value > std::numeric_limits<int64_t>::max() / positive_value
               ? Max()
               : value < -std::numeric_limits<int64_t>::max() / positive_value
                     ? -Max()
                     : TimeDelta(value * positive_value));
 }
 
 // For logging use only.
 BASE_EXPORT std::ostream& operator<<(std::ostream& os, Time time);
 
@@ skipping 136 matching lines @@
   static void WaitUntilInitializedWin();
 #endif
 };
 
 // For logging use only.
 BASE_EXPORT std::ostream& operator<<(std::ostream& os, ThreadTicks time_ticks);
 
 }  // namespace base
 
 #endif  // BASE_TIME_TIME_H_