Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2104863002: Replace unused output parameter in VCMReceiver::FrameForDecoding(). (Closed)

Created:
4 years, 5 months ago by johan
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused output parameter in VCMReceiver::FrameForDecoding(). BUG= R=pbos@webrtc.org Committed: https://crrev.com/31b2ec4e0df1bd2ed24bfdd79acde69b9ffc821e Cr-Commit-Position: refs/heads/master@{#13310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -22 lines) Patch
M webrtc/modules/video_coding/receiver.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/receiver.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/receiver_unittest.cc View 5 chunks +4 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
johan
4 years, 5 months ago (2016-06-28 10:41:41 UTC) #2
pbos-webrtc
lgtm, please put "Remove" instead of "Replace" in the CL description
4 years, 5 months ago (2016-06-28 11:05:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2104863002/1
4 years, 5 months ago (2016-06-28 11:20:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/9070)
4 years, 5 months ago (2016-06-28 11:30:36 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/31b2ec4e0df1bd2ed24bfdd79acde69b9ffc821e Cr-Commit-Position: refs/heads/master@{#13310}
4 years, 5 months ago (2016-06-28 11:33:05 UTC) #11
johan
4 years, 5 months ago (2016-06-28 11:33:05 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
31b2ec4e0df1bd2ed24bfdd79acde69b9ffc821e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698