Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2104813003: AndroidVideoCapturer: Remove unused member variable (Closed)

Created:
4 years, 5 months ago by magjed_webrtc
Modified:
4 years, 5 months ago
Reviewers:
tommi, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

AndroidVideoCapturer: Remove unused member variable The member variable |current_state_| in AndroidVideoCapturer is unnecessary. All state changes are reported to the base class cricket::VideoCapturer that already holds the capture state. R=sakal@webrtc.org, tommi@webrtc.org Committed: https://crrev.com/77ed80a7ef5af68e77d8c1e4d6cdb581fb257eee Cr-Commit-Position: refs/heads/master@{#13341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M webrtc/api/androidvideocapturer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/api/androidvideocapturer.cc View 4 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
magjed_webrtc
Sami - Please take a look.
4 years, 5 months ago (2016-06-28 14:16:19 UTC) #3
sakal
lgtm
4 years, 5 months ago (2016-06-28 14:51:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2104813003/1
4 years, 5 months ago (2016-06-29 08:28:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14579)
4 years, 5 months ago (2016-06-29 08:37:38 UTC) #8
magjed_webrtc
tommi - Please rubber stamp.
4 years, 5 months ago (2016-06-29 09:44:24 UTC) #10
tommi
lgtm
4 years, 5 months ago (2016-06-29 14:56:35 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/77ed80a7ef5af68e77d8c1e4d6cdb581fb257eee Cr-Commit-Position: refs/heads/master@{#13341}
4 years, 5 months ago (2016-06-30 08:05:51 UTC) #14
magjed_webrtc
4 years, 5 months ago (2016-06-30 08:05:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
77ed80a7ef5af68e77d8c1e4d6cdb581fb257eee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698