A simple copy of the old mixer to a new directory. I also plan to run 'git cl format'. In another C…

A simple copy of the old audio mixer to a new directory.

I have added build files and renamed the mixer so that it doesn't conflict with the old one. The header includes now point to this copy of the mixer. I have also fixed some of the more obvious cases of style guide non-conformance and run 'PRESUBMIT' on the old mixer.

This is a first step in the creation of a new mixing module that will replace AudioConferencMixer and OutputMixer.

NOTRY=True

Committed: https://crrev.com/77ad394fa6680aa9fb36d0bcac330dd84b29dfc2
Cr-Commit-Position: refs/heads/master@{#13378}

[aleloi2, 2016-06-30 13:38:31]

Description was changed from

==========
A simple copy of the old mixer to a new directory. I also plan to run 'git cl
format'. In another CL, I plan to add a build file and rename the mixer so that
it doesn't conflict with the old one. I also plan to change the header includes
to point to this copy of the mixer.

This is a first step in the creation of a new mixing module that will replace
AudioConferencMixer and OutputMixer. See the design doc:

https://docs.google.com/document/d/13WbsqJJXCOvS4Pq8lr2BmdQGtFWnvbVpvipOHVH2k...

NOTRY=True
==========

to

==========
A simple copy of the old mixer to a new directory. I also plan to run 'git cl
format'. In another CL, I plan to add a build file and rename the mixer so that
it doesn't conflict with the old one. I also plan to change the header includes
to point to this copy of the mixer.

This is a first step in the creation of a new mixing module that will replace
AudioConferencMixer and OutputMixer. See the design doc:

https://docs.google.com/document/d/13WbsqJJXCOvS4Pq8lr2BmdQGtFWnvbVpvipOHVH2k...

NOTRY=True
==========

[aleloi2, 2016-06-30 13:38:31]

aleloi@google.com changed reviewers:
+ ivoc@webrtc.org

[aleloi2, 2016-06-30 15:04:15]

aleloi@google.com changed reviewers:
+ aleloi@google.com

[aleloi2, 2016-06-30 15:04:15]

PTAL

[aleloi2, 2016-06-30 15:16:50]

aleloi@google.com changed reviewers:
+ henrik.lundin@webrtc.org
- aleloi@google.com

[aleloi, 2016-06-30 15:20:17]

As I understood it during offline discussions with hlundin@ and ossu@, the plan
was to copy the new mixer to a new place, rewrite it, and then connect the rest
of WebRTC to it. Eventually the old mixer will be removed.

Are we all on the same page?

[ivoc, 2016-06-30 15:30:02]

On 2016/06/30 15:20:17, aleloi wrote:
> As I understood it during offline discussions with hlundin@ and ossu@, the
plan
> was to copy the new mixer to a new place, rewrite it, and then connect the
rest
> of WebRTC to it. Eventually the old mixer will be removed.
> 
> Are we all on the same page?

I missed the discussion about this, so you guys probably thought this through.
Is it really okay to add files to the repo that are not used anywhere and not
included in the build? 
Also, you should add yourself to the OWNERS file.

[ossu, 2016-06-30 15:43:51]

On 2016/06/30 15:30:02, ivoc wrote:
> On 2016/06/30 15:20:17, aleloi wrote:
> > As I understood it during offline discussions with hlundin@ and ossu@, the
> plan
> > was to copy the new mixer to a new place, rewrite it, and then connect the
> rest
> > of WebRTC to it. Eventually the old mixer will be removed.
> > 
> > Are we all on the same page?
> 
> I missed the discussion about this, so you guys probably thought this through.
> Is it really okay to add files to the repo that are not used anywhere and not
> included in the build? 
> Also, you should add yourself to the OWNERS file.

Hmm. I guess it should be safe for our builds, but it might confuse other tools,
like codesearch and gtags, which will find two definitions of the same code and
it won't be clear which is actually being used. Maybe you should try to minimize
the code being copied to what you think you'll actually change, i.e.
audio_conference_mixer and maybe output_mixer, and just let them use the old
audio conference mixer stuff that you plan to move away from (memory pool, time
scheduler?) in-place. Oh, and rename those two that you copied, or at least put
them in an internal namespace while working on them.

The git cl format looks good though. :)

[ossu, 2016-06-30 15:44:02]

ossu@webrtc.org changed reviewers:
+ ossu@webrtc.org

[ossu, 2016-06-30 15:44:03]

https://codereview.webrtc.org/2104363003/diff/1/webrtc/modules/audio_mixer/ou...
File webrtc/modules/audio_mixer/output_mixer.cc (right):

https://codereview.webrtc.org/2104363003/diff/1/webrtc/modules/audio_mixer/ou...
webrtc/modules/audio_mixer/output_mixer.cc:43: // Not implement yet
This ...

https://codereview.webrtc.org/2104363003/diff/1/webrtc/modules/audio_mixer/ou...
webrtc/modules/audio_mixer/output_mixer.cc:53: // Not implement yet
... is ...

https://codereview.webrtc.org/2104363003/diff/1/webrtc/modules/audio_mixer/ou...
webrtc/modules/audio_mixer/output_mixer.cc:61: // not needed
... lovely :)

https://codereview.webrtc.org/2104363003/diff/20001/webrtc/modules/audio_mixe...
File webrtc/modules/audio_mixer/include/audio_conference_mixer.h (right):

https://codereview.webrtc.org/2104363003/diff/20001/webrtc/modules/audio_mixe...
webrtc/modules/audio_mixer/include/audio_conference_mixer.h:27: kNbInHz = 8000,
I kinda like when things are aligned vertically; it makes it easier to read and
edit. Though it might be something to consider once you _actually_ start
rewriting these files.

[aleloi, 2016-06-30 16:37:54]

I was planning to rename the files in a next CL. But as ossu@ says, it would
imply that WebRTC is in a strange state for a while.

I have renamed all components. If this directory were connected to the build
system, it would now compile (tested locally).


I removed files containing the first components to be removed. It's
TimeScheduler and MemoryPool. The components are still used in this version of
the mixer, but they point to the old mixer.

[ivoc, 2016-07-01 07:56:27]

https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/audio_mixer.cc (right):

https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/audio_mixer.cc:194: bool mixable)
Formatting seems off (nr of spaces)

https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/audio_mixer.cc:201: bool mixable)
And here.

https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/audio_mixer.h (right):

https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/audio_mixer.h:33: public FileCallback
You may want to rerun git cl format, I think this should be shifted one space to
the left

https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/include/audio_conference_mixer.h (right):

https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/include/audio_conference_mixer.h:23: class
NewAudioConferenceMixer : public Module {
I'm not a big fan of this style of naming things (New...), are you planning to
change it later at some point?

[aleloi, 2016-07-01 08:12:35]

I did a new 'cl format' that fixed indentation in audio_mixer.*

https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/include/audio_conference_mixer.h (right):

https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/include/audio_conference_mixer.h:23: class
NewAudioConferenceMixer : public Module {
On 2016/07/01 07:56:27, ivoc wrote:
> I'm not a big fan of this style of naming things (New...), are you planning to
> change it later at some point?

Yes, I plan to merge both mixers into one called 'AudioMixer'.

[ossu, 2016-07-01 08:39:50]

https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/include/audio_conference_mixer.h (right):

https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/include/audio_conference_mixer.h:23: class
NewAudioConferenceMixer : public Module {
On 2016/07/01 08:12:35, aleloi wrote:
> On 2016/07/01 07:56:27, ivoc wrote:
> > I'm not a big fan of this style of naming things (New...), are you planning
to
> > change it later at some point?
> 
> Yes, I plan to merge both mixers into one called 'AudioMixer'.

Why not call it AudioMixer right now?

https://codereview.webrtc.org/2104363003/diff/120001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/audio_mixer.h (right):

https://codereview.webrtc.org/2104363003/diff/120001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/audio_mixer.h:11: #ifndef
WEBRTC_VOICE_ENGINE_OUTPUT_MIXER_H_
You'll need to rename the include guards as well; they should match the path to
the file. This applies to all the header files, but I'm not going to add a
comment for each. :)

See: https://google.github.io/styleguide/cppguide.html#The__define_Guard

[aleloi, 2016-07-01 09:12:27]

Updated header guards.

https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/include/audio_conference_mixer.h (right):

https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/include/audio_conference_mixer.h:23: class
NewAudioConferenceMixer : public Module {
On 2016/07/01 08:39:50, ossu wrote:
> On 2016/07/01 08:12:35, aleloi wrote:
> > On 2016/07/01 07:56:27, ivoc wrote:
> > > I'm not a big fan of this style of naming things (New...), are you
planning
> to
> > > change it later at some point?
> > 
> > Yes, I plan to merge both mixers into one called 'AudioMixer'.
> 
> Why not call it AudioMixer right now?

The other mixer previously known as 'OutputMixer' is named 'AudioMixer' now.
Maybe we should rename this one into 'LegacyAudioConferenceMixer'?

[hlundin-webrtc, 2016-07-01 11:55:25]

On 2016/07/01 09:12:27, aleloi wrote:
> Updated header guards.
> 
>
https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
> File webrtc/modules/audio_mixer/include/audio_conference_mixer.h (right):
> 
>
https://codereview.webrtc.org/2104363003/diff/100001/webrtc/modules/audio_mix...
> webrtc/modules/audio_mixer/include/audio_conference_mixer.h:23: class
> NewAudioConferenceMixer : public Module {
> On 2016/07/01 08:39:50, ossu wrote:
> > On 2016/07/01 08:12:35, aleloi wrote:
> > > On 2016/07/01 07:56:27, ivoc wrote:
> > > > I'm not a big fan of this style of naming things (New...), are you
> planning
> > to
> > > > change it later at some point?
> > > 
> > > Yes, I plan to merge both mixers into one called 'AudioMixer'.
> > 
> > Why not call it AudioMixer right now?
> 
> The other mixer previously known as 'OutputMixer' is named 'AudioMixer' now.
> Maybe we should rename this one into 'LegacyAudioConferenceMixer'?

Format the commit message as follows

"
Short title of the change that fits on one line

Longer description, with words, and stuff...
"

[hlundin-webrtc, 2016-07-01 12:10:04]

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/BUILD.gn (right):

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/BUILD.gn:1: # Copyright (c) 2014 The WebRTC project
authors. All Rights Reserved.
The same changes to gypi?

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/BUILD.gn:20: "audio_mixer.h",
Shouldn't you include all files that you copied?

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/audio_mixer.h (right):

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/audio_mixer.h:32: class AudioMixer : public
AudioMixerOutputReceiver, public FileCallback {
You may want to add a comment saying that this is scheduled for heavy
refactoring, and that the API will change.

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/include/audio_conference_mixer.h (right):

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/include/audio_conference_mixer.h:23: class
NewAudioConferenceMixer : public Module {
The file name should reflect the name of the class. That is
new_audio_conference_mixer.h.

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/include/audio_conference_mixer_defines.h
(right):

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/include/audio_conference_mixer_defines.h:11: #ifndef
WEBRTC_MODULES_AUDIO_MIXER_INCLUDE_AUDIO_CONFERENCE_MIXER_DEFINES_H_
I suggest you rename this file to audio_mixer_defines.h.

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/source/audio_conference_mixer_impl.h (right):

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/source/audio_conference_mixer_impl.h:59: class
NewAudioConferenceMixerImpl : public NewAudioConferenceMixer {
Rename file.

[aleloi, 2016-07-01 14:16:29]

New patch set:

1. Added GN and gyp build files
2. Connected this folder to the rest of the build system
3. Renamed files to match class names
4. Renamed the OutputReceiver so that it doesn't conflict with the one currently
used.

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/BUILD.gn (right):

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/BUILD.gn:20: "audio_mixer.h",
On 2016/07/01 12:10:03, hlundin-webrtc wrote:
> Shouldn't you include all files that you copied?

They are included in the target 'audio_conference_mixer' below. This target
depends on that.

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/audio_mixer.h (right):

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/audio_mixer.h:32: class AudioMixer : public
AudioMixerOutputReceiver, public FileCallback {
On 2016/07/01 12:10:03, hlundin-webrtc wrote:
> You may want to add a comment saying that this is scheduled for heavy
> refactoring, and that the API will change.

Done.

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/include/audio_conference_mixer.h (right):

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/include/audio_conference_mixer.h:23: class
NewAudioConferenceMixer : public Module {
On 2016/07/01 12:10:03, hlundin-webrtc wrote:
> The file name should reflect the name of the class. That is
> new_audio_conference_mixer.h.

Done.

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/include/audio_conference_mixer_defines.h
(right):

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/include/audio_conference_mixer_defines.h:11: #ifndef
WEBRTC_MODULES_AUDIO_MIXER_INCLUDE_AUDIO_CONFERENCE_MIXER_DEFINES_H_
On 2016/07/01 12:10:04, hlundin-webrtc wrote:
> I suggest you rename this file to audio_mixer_defines.h.

Done.

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/source/audio_conference_mixer_impl.h (right):

https://codereview.webrtc.org/2104363003/diff/140001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/source/audio_conference_mixer_impl.h:59: class
NewAudioConferenceMixerImpl : public NewAudioConferenceMixer {
On 2016/07/01 12:10:04, hlundin-webrtc wrote:
> Rename file.

Done.

[ivoc, 2016-07-04 12:07:23]

Getting close, see some small points below.

https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/audio_mixer.cc (right):

https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/audio_mixer.cc:40: // Not implement yet
Not implemented yet. (see also below)

https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/audio_mixer.cc:55: // not needed
Not needed.

https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/audio_mixer.cc:264: "StartRecordingPlayout()
fileRecorder format isnot correct");
isnot -> is not (see also several times below)

https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/include/audio_mixer_defines.h (right):

https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/include/audio_mixer_defines.h:73: virtual void
NewMixedAudio(const int32_t id,
The naming is pretty interesting here, the class is old, but the member function
is new? It looks a bit strange to me :-)

[aleloi, 2016-07-04 12:34:36]

Description was changed from

==========
A simple copy of the old mixer to a new directory. I also plan to run 'git cl
format'. In another CL, I plan to add a build file and rename the mixer so that
it doesn't conflict with the old one. I also plan to change the header includes
to point to this copy of the mixer.

This is a first step in the creation of a new mixing module that will replace
AudioConferencMixer and OutputMixer. See the design doc:

https://docs.google.com/document/d/13WbsqJJXCOvS4Pq8lr2BmdQGtFWnvbVpvipOHVH2k...

NOTRY=True
==========

to

==========
A simple copy of the old audio mixer to a new directory.

I have added build files and renamed the mixer so that it doesn't conflict with
the old one. The header includes now point to this copy of the mixer.

This is a first step in the creation of a new mixing module that will replace
AudioConferencMixer and OutputMixer.

NOTRY=True
==========

[aleloi, 2016-07-04 12:34:45]

https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/audio_mixer.cc (right):

https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/audio_mixer.cc:40: // Not implement yet
On 2016/07/04 12:07:23, ivoc wrote:
> Not implemented yet. (see also below)

Acknowledged.

https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/audio_mixer.cc:55: // not needed
On 2016/07/04 12:07:23, ivoc wrote:
> Not needed.

Acknowledged.

https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/audio_mixer.cc:264: "StartRecordingPlayout()
fileRecorder format isnot correct");
On 2016/07/04 12:07:23, ivoc wrote:
> isnot -> is not (see also several times below)

Acknowledged.

https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/include/audio_mixer_defines.h (right):

https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/include/audio_mixer_defines.h:73: virtual void
NewMixedAudio(const int32_t id,
On 2016/07/04 12:07:23, ivoc wrote:
> The naming is pretty interesting here, the class is old, but the member
function
> is new? It looks a bit strange to me :-)

Acknowledged.

[ivoc, 2016-07-04 12:36:23]

On 2016/07/04 12:34:45, aleloi wrote:
>
https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
> File webrtc/modules/audio_mixer/audio_mixer.cc (right):
> 
>
https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
> webrtc/modules/audio_mixer/audio_mixer.cc:40: // Not implement yet
> On 2016/07/04 12:07:23, ivoc wrote:
> > Not implemented yet. (see also below)
> 
> Acknowledged.
> 
>
https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
> webrtc/modules/audio_mixer/audio_mixer.cc:55: // not needed
> On 2016/07/04 12:07:23, ivoc wrote:
> > Not needed.
> 
> Acknowledged.
> 
>
https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
> webrtc/modules/audio_mixer/audio_mixer.cc:264: "StartRecordingPlayout()
> fileRecorder format isnot correct");
> On 2016/07/04 12:07:23, ivoc wrote:
> > isnot -> is not (see also several times below)
> 
> Acknowledged.
> 
>
https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
> File webrtc/modules/audio_mixer/include/audio_mixer_defines.h (right):
> 
>
https://codereview.webrtc.org/2104363003/diff/180001/webrtc/modules/audio_mix...
> webrtc/modules/audio_mixer/include/audio_mixer_defines.h:73: virtual void
> NewMixedAudio(const int32_t id,
> On 2016/07/04 12:07:23, ivoc wrote:
> > The naming is pretty interesting here, the class is old, but the member
> function
> > is new? It looks a bit strange to me :-)
> 
> Acknowledged.

LGTM.

[aleloi, 2016-07-04 12:37:36]

The CQ bit was checked by aleloi@webrtc.org

[commit-bot: I haz the power, 2016-07-04 12:37:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-04 12:39:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-04 12:39:58]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6672)

[aleloi, 2016-07-04 12:58:39]

The CQ bit was checked by aleloi@webrtc.org

[aleloi, 2016-07-04 12:58:40]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2104363003/#ps200001 (title:
"Added voice engine dependency.")

[commit-bot: I haz the power, 2016-07-04 12:58:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-04 13:01:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-04 13:01:49]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6674)

[ossu, 2016-07-04 13:13:22]

On 2016/07/04 13:01:49, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   presubmit on master.tryserver.webrtc (JOB_FAILED,
> http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6674)

I guess you need some owner approval as well. git cl owners can help you find
one.

[aleloi, 2016-07-04 13:30:46]

Description was changed from

==========
A simple copy of the old audio mixer to a new directory.

I have added build files and renamed the mixer so that it doesn't conflict with
the old one. The header includes now point to this copy of the mixer.

This is a first step in the creation of a new mixing module that will replace
AudioConferencMixer and OutputMixer.

NOTRY=True
==========

to

==========
A simple copy of the old audio mixer to a new directory.

I have added build files and renamed the mixer so that it doesn't conflict with
the old one. The header includes now point to this copy of the mixer. I have
also fixed some of the more obvious cases of style guide non-conformance and run
'PRESUBMIT' on the old mixer.

This is a first step in the creation of a new mixing module that will replace
AudioConferencMixer and OutputMixer.

NOTRY=True
==========

[aleloi, 2016-07-04 13:30:53]

The CQ bit was checked by aleloi@webrtc.org

[aleloi, 2016-07-04 13:30:54]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2104363003/#ps220001 (title:
"Fixed cpplint complaints in old code.")

[commit-bot: I haz the power, 2016-07-04 13:31:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-04 13:33:05]

Description was changed from

==========
A simple copy of the old audio mixer to a new directory.

I have added build files and renamed the mixer so that it doesn't conflict with
the old one. The header includes now point to this copy of the mixer. I have
also fixed some of the more obvious cases of style guide non-conformance and run
'PRESUBMIT' on the old mixer.

This is a first step in the creation of a new mixing module that will replace
AudioConferencMixer and OutputMixer.

NOTRY=True
==========

to

==========
A simple copy of the old audio mixer to a new directory.

I have added build files and renamed the mixer so that it doesn't conflict with
the old one. The header includes now point to this copy of the mixer. I have
also fixed some of the more obvious cases of style guide non-conformance and run
'PRESUBMIT' on the old mixer.

This is a first step in the creation of a new mixing module that will replace
AudioConferencMixer and OutputMixer.

NOTRY=True
==========

[commit-bot: I haz the power, 2016-07-04 13:33:06]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-07-04 13:33:09]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-04 13:33:13]

Description was changed from

==========
A simple copy of the old audio mixer to a new directory.

I have added build files and renamed the mixer so that it doesn't conflict with
the old one. The header includes now point to this copy of the mixer. I have
also fixed some of the more obvious cases of style guide non-conformance and run
'PRESUBMIT' on the old mixer.

This is a first step in the creation of a new mixing module that will replace
AudioConferencMixer and OutputMixer.

NOTRY=True
==========

to

==========
A simple copy of the old audio mixer to a new directory.

I have added build files and renamed the mixer so that it doesn't conflict with
the old one. The header includes now point to this copy of the mixer. I have
also fixed some of the more obvious cases of style guide non-conformance and run
'PRESUBMIT' on the old mixer.

This is a first step in the creation of a new mixing module that will replace
AudioConferencMixer and OutputMixer.

NOTRY=True

Committed: https://crrev.com/77ad394fa6680aa9fb36d0bcac330dd84b29dfc2
Cr-Commit-Position: refs/heads/master@{#13378}
==========

[commit-bot: I haz the power, 2016-07-04 13:33:15]

Patchset 12 (id:??) landed as
https://crrev.com/77ad394fa6680aa9fb36d0bcac330dd84b29dfc2
Cr-Commit-Position: refs/heads/master@{#13378}