Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2104203002: Fixing flakiness of TestDetectUnresolvedProxy. (Closed)

Created:
4 years, 5 months ago by Taylor Brandstetter
Modified:
4 years, 5 months ago
Reviewers:
Zhi Huang, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing flakiness of TestDetectUnresolvedProxy. If the AutoDetectProxy timed out resolving one address, it was attempting to use the same resolver to resolve the next address, which would always result in an assertion. This happened recently a couple times on the Windows DrMemory bot because of its slowness. TBR=pthatcher@webrtc.org Committed: https://crrev.com/54433e72aabb2b01aa1c5c7b6a2ba91c2c01b348 Cr-Commit-Position: refs/heads/master@{#13326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M webrtc/base/autodetectproxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/autodetectproxy.cc View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Taylor Brandstetter
4 years, 5 months ago (2016-06-28 22:29:30 UTC) #2
Taylor Brandstetter
Committed patchset #1 (id:1) manually as 54433e72aabb2b01aa1c5c7b6a2ba91c2c01b348 (presubmit successful).
4 years, 5 months ago (2016-06-29 17:10:46 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/54433e72aabb2b01aa1c5c7b6a2ba91c2c01b348 Cr-Commit-Position: refs/heads/master@{#13326}
4 years, 5 months ago (2016-06-29 17:10:46 UTC) #7
Zhi Huang
4 years, 5 months ago (2016-06-29 17:16:22 UTC) #8
Message was sent while issue was closed.
On 2016/06/28 22:29:30, Taylor Brandstetter wrote:

Sorry for the late reply as I'm not very familiar with the code in this area.
But the CL looks goods.  LGTM.

Powered by Google App Engine
This is Rietveld 408576698