webrtc/modules/audio_device/audio_device.gypi - Issue 2103863004: UMA log for audio_device Init and Start(Playout|Recording). Make Init return a more specific error …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_device/audio_device.gypi

Issue 2103863004: UMA log for audio_device Init and Start(Playout|Recording). Make Init return a more specific error … (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix more silly errors. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_device/android/audio_device_template.h ('k') | webrtc/modules/audio_device/audio_device_generic.h » ('j') | webrtc/modules/audio_device/audio_device_generic.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_device/audio_device.gypi

diff --git a/webrtc/modules/audio_device/audio_device.gypi b/webrtc/modules/audio_device/audio_device.gypi

index a7c578965852cf9063d5733cacf3cd63b3988873..36b077cb27e8429bdab3882fe6854c5b645d9391 100644

--- a/webrtc/modules/audio_device/audio_device.gypi

+++ b/webrtc/modules/audio_device/audio_device.gypi

@@ -16,7 +16,7 @@

'<(webrtc_root)/base/base.gyp:rtc_base_approved',

'<(webrtc_root)/common.gyp:webrtc_common',

'<(webrtc_root)/common_audio/common_audio.gyp:common_audio',

- '<(webrtc_root)/system_wrappers/system_wrappers.gyp:system_wrappers',

+ '<(webrtc_root)/system_wrappers/system_wrappers.gyp:system_wrappers_default',

henrika_webrtc 2016/06/30 08:44:20 Why was this needed?

Max Morin WebRTC 2016/06/30 10:56:04 For linking with metrics. I made the dependencies

'include_dirs': [

'.',

@@ -259,7 +259,7 @@

'webrtc_utility',

'<(webrtc_root)/test/test.gyp:test_support_main',

'<(DEPTH)/testing/gtest.gyp:gtest',

- '<(webrtc_root)/system_wrappers/system_wrappers.gyp:system_wrappers',

+ '<(webrtc_root)/system_wrappers/system_wrappers.gyp:system_wrappers_default',

'sources': [

'test/audio_device_test_api.cc',

@@ -273,7 +273,7 @@

'audio_device',

'webrtc_utility',

'<(webrtc_root)/common_audio/common_audio.gyp:common_audio',

- '<(webrtc_root)/system_wrappers/system_wrappers.gyp:system_wrappers',

+ '<(webrtc_root)/system_wrappers/system_wrappers.gyp:system_wrappers_default',

'<(webrtc_root)/test/test.gyp:test_support',

'<(DEPTH)/testing/gtest.gyp:gtest',