UMA log for audio_device Init and Start(Playout|Recording). Make Init return a more specific error …

webrtc/modules/audio_device/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../../build/webrtc.gni")
 
 config("audio_device_config") {
   include_dirs = [
     "../include",
     "include",
     "dummy",  # Contains dummy audio device implementations.
   ]
   if (is_ios) {
     # GN orders flags on a target before flags from configs. In order to be able
     # suppress the -Wthread-safety-analysis warning, it has come from a config
     # and can't be on the target directly.
     # TODO(tkchin): Remove after fixing
     # https://bugs.chromium.org/p/webrtc/issues/detail?id=5748
     cflags = [ "-Wno-thread-safety-analysis" ]
   }
 }
 
 source_set("audio_device") {
   deps = [
     "../..:webrtc_common",
+    "../../base:rtc_base",

[kjellander_webrtc, 2016/09/14 19:47:15]

We try to avoid this dependency (but we haven't updated the PRESUBMIT check for
GN, it only exists for GYP). Is this dependency really needed here?

If so, it should be added to GYP too, but ideally it wouldn't be needed.

     "../../base:rtc_base_approved",
     "../../common_audio",
     "../../system_wrappers",
     "../utility",
   ]
 
   sources = [
     "audio_device_buffer.cc",
     "audio_device_buffer.h",
     "audio_device_config.h",
@@ skipping 162 matching lines @@
     "../..:common_inherited_config",
     ":audio_device_config",
   ]
 
   if (is_clang) {
     # Suppress warnings from Chrome's Clang plugins.
     # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
     configs -= [ "//build/config/clang:find_bad_constructs" ]
   }
 }