Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2102603002: Fixing a comment on AEC divergence metric. (Closed)

Created:
4 years, 5 months ago by minyue-webrtc
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
minyue-webrtc
Hi, Henrik found an error in this comment. Thanks! This is a fix.
4 years, 5 months ago (2016-06-27 14:46:35 UTC) #3
hlundin-webrtc
lgtm
4 years, 5 months ago (2016-06-27 14:50:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2102603002/1
4 years, 5 months ago (2016-06-27 14:50:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14502)
4 years, 5 months ago (2016-06-27 14:57:52 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e01000b9a48eab52b6f5adca17f704c3d3aa2e92 Cr-Commit-Position: refs/heads/master@{#13297}
4 years, 5 months ago (2016-06-27 15:06:27 UTC) #10
minyue-webrtc
4 years, 5 months ago (2016-06-27 15:06:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e01000b9a48eab52b6f5adca17f704c3d3aa2e92 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698