Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Unified Diff: webrtc/common_video/incoming_video_stream.cc

Issue 2100083002: Remove a thread checker for a decoder thread from IncomingVideoStream. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/common_video/include/incoming_video_stream.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/common_video/incoming_video_stream.cc
diff --git a/webrtc/common_video/incoming_video_stream.cc b/webrtc/common_video/incoming_video_stream.cc
index 8deca0fc8323e2a31b4e852b06c7b9e6781d3df5..f5a52fcba335f25d1a1a7b7d53773d519d3aec5f 100644
--- a/webrtc/common_video/incoming_video_stream.cc
+++ b/webrtc/common_video/incoming_video_stream.cc
@@ -29,7 +29,6 @@ IncomingVideoStream::IncomingVideoStream(
RTC_DCHECK(external_callback_);
render_thread_checker_.DetachFromThread();
- decoder_thread_checker_.DetachFromThread();
incoming_render_thread_.Start();
incoming_render_thread_.SetPriority(rtc::kRealtimePriority);
@@ -50,7 +49,8 @@ IncomingVideoStream::~IncomingVideoStream() {
}
void IncomingVideoStream::OnFrame(const VideoFrame& video_frame) {
- RTC_DCHECK_RUN_ON(&decoder_thread_checker_);
+ // Most of the time we'll be on a decoder thread here, but when using
+ // VideoToolbox on iOS, we'll get called on a thread from a thread pool.
// Hand over or insert frame.
rtc::CritScope csB(&buffer_critsect_);
« no previous file with comments | « webrtc/common_video/include/incoming_video_stream.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698