Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Unified Diff: webrtc/p2p/base/turnport_unittest.cc

Issue 2099783002: Fixing bug where Connection drops packets when presumed writable. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/turnport_unittest.cc
diff --git a/webrtc/p2p/base/turnport_unittest.cc b/webrtc/p2p/base/turnport_unittest.cc
index 077ca4d7f1f35ccd6382213f9fdb6b4bc2feb1ec..8c83139a1a624036d6962c24917745d5f2da15e0 100644
--- a/webrtc/p2p/base/turnport_unittest.cc
+++ b/webrtc/p2p/base/turnport_unittest.cc
@@ -960,12 +960,12 @@ TEST_F(TurnPortTest, TestChannelBindGetErrorResponse) {
EXPECT_TRUE_SIMULATED_WAIT(CheckConnectionFailedAndPruned(conn1), kTimeout,
clock);
- // Verify that no packet can be sent after a bind request error.
+ // Verify that packets are allowed to be sent after a bind request error.
+ // They'll just use a send indication instead.
conn2->SignalReadPacket.connect(static_cast<TurnPortTest*>(this),
&TurnPortTest::OnUdpReadPacket);
conn1->Send(data.data(), data.length(), options);
- SIMULATED_WAIT(!udp_packets_.empty(), kTimeout, clock);
- EXPECT_TRUE(udp_packets_.empty());
+ EXPECT_TRUE_SIMULATED_WAIT(!udp_packets_.empty(), kTimeout, clock);
}
// Do a TURN allocation, establish a UDP connection, and send some data.

Powered by Google App Engine
This is Rietveld 408576698