Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: webrtc/p2p/base/transport.cc

Issue 2099563004: Start ICE connectivity checks as soon as the first pair is pingable. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Removing debug log message, adding missing UpdateState. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/transport.h ('k') | webrtc/p2p/base/transport_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/transport.cc
diff --git a/webrtc/p2p/base/transport.cc b/webrtc/p2p/base/transport.cc
index 33c52776ada4403d375b506a90059d91f6962518..9fbe9524c3ae0b7a3115c3c85eb268a052fd0888 100644
--- a/webrtc/p2p/base/transport.cc
+++ b/webrtc/p2p/base/transport.cc
@@ -114,7 +114,6 @@ bool Transport::SetLocalTransportDescription(
}
if (ret) {
local_description_set_ = true;
- ConnectChannels();
}
return ret;
@@ -181,9 +180,6 @@ TransportChannelImpl* Transport::CreateChannel(int component) {
if (local_description_ && remote_description_)
ApplyNegotiatedTransportDescription(channel, nullptr);
- if (connect_requested_) {
- channel->Connect();
- }
return channel;
}
@@ -206,21 +202,8 @@ void Transport::DestroyChannel(int component) {
DestroyTransportChannel(channel);
}
-void Transport::ConnectChannels() {
- if (connect_requested_ || channels_.empty())
- return;
-
- connect_requested_ = true;
-
- RTC_DCHECK(local_description_);
-
- CallChannels(&TransportChannelImpl::Connect);
-}
-
void Transport::MaybeStartGathering() {
- if (connect_requested_) {
- CallChannels(&TransportChannelImpl::MaybeStartGathering);
- }
+ CallChannels(&TransportChannelImpl::MaybeStartGathering);
}
void Transport::DestroyAllChannels() {
« no previous file with comments | « webrtc/p2p/base/transport.h ('k') | webrtc/p2p/base/transport_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698