Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Unified Diff: webrtc/p2p/base/port.cc

Issue 2099563004: Start ICE connectivity checks as soon as the first pair is pingable. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Code style fixes, renaming some methods, calling MaybeStartPinging in a different place. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/port.cc
diff --git a/webrtc/p2p/base/port.cc b/webrtc/p2p/base/port.cc
index ab7ba09ea513a61a8876a4ad47999a1a6aa57d11..00fac05d9423ff7368683f969079c64aa4bf927f 100644
--- a/webrtc/p2p/base/port.cc
+++ b/webrtc/p2p/base/port.cc
@@ -924,6 +924,7 @@ void Connection::set_connected(bool value) {
if (value != old_value) {
LOG_J(LS_VERBOSE, this) << "set_connected from: " << old_value << " to "
<< value;
+ SignalStateChange(this);
}
}
@@ -1233,7 +1234,7 @@ bool Connection::dead(int64_t now) const {
return now > (time_created_ms_ + MIN_CONNECTION_LIFETIME);
}
-bool Connection::stable(int64_t now) {
+bool Connection::stable(int64_t now) const {
// A connection is stable if it's RTT has converged and it isn't missing any
// responses. We should send pings at a higher rate until the RTT converges
// and whenever a ping response is missing (so that we can detect
@@ -1505,11 +1506,11 @@ void Connection::MaybeAddPrflxCandidate(ConnectionRequest* request,
SignalStateChange(this);
}
-bool Connection::rtt_converged() {
+bool Connection::rtt_converged() const {
return rtt_samples_ > (RTT_RATIO + 1);
}
-bool Connection::missing_responses(int64_t now) {
+bool Connection::missing_responses(int64_t now) const {
if (pings_since_last_response_.empty()) {
return false;
}

Powered by Google App Engine
This is Rietveld 408576698