Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: webrtc/p2p/base/transportchannelimpl.h

Issue 2099563004: Start ICE connectivity checks as soon as the first pair is pingable. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Removing debug log message, adding missing UpdateState. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/p2p/base/transport_unittest.cc ('k') | webrtc/p2p/base/transportcontroller_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 28 matching lines...) Expand all
39 39
40 // For ICE channels. 40 // For ICE channels.
41 virtual IceRole GetIceRole() const = 0; 41 virtual IceRole GetIceRole() const = 0;
42 virtual void SetIceRole(IceRole role) = 0; 42 virtual void SetIceRole(IceRole role) = 0;
43 virtual void SetIceTiebreaker(uint64_t tiebreaker) = 0; 43 virtual void SetIceTiebreaker(uint64_t tiebreaker) = 0;
44 // TODO(pthatcher): Remove this once it's no longer called in 44 // TODO(pthatcher): Remove this once it's no longer called in
45 // remoting/protocol/libjingle_transport_factory.cc 45 // remoting/protocol/libjingle_transport_factory.cc
46 virtual void SetIceProtocolType(IceProtocolType type) {} 46 virtual void SetIceProtocolType(IceProtocolType type) {}
47 // SetIceCredentials only need to be implemented by the ICE 47 // SetIceCredentials only need to be implemented by the ICE
48 // transport channels. Non-ICE transport channels can just ignore. 48 // transport channels. Non-ICE transport channels can just ignore.
49 // The ufrag and pwd should be set before the Connect() is called. 49 // The ufrag and pwd must be set before candidate gathering can start.
50 virtual void SetIceCredentials(const std::string& ice_ufrag, 50 virtual void SetIceCredentials(const std::string& ice_ufrag,
51 const std::string& ice_pwd) = 0; 51 const std::string& ice_pwd) = 0;
52 // SetRemoteIceCredentials only need to be implemented by the ICE 52 // SetRemoteIceCredentials only need to be implemented by the ICE
53 // transport channels. Non-ICE transport channels can just ignore. 53 // transport channels. Non-ICE transport channels can just ignore.
54 virtual void SetRemoteIceCredentials(const std::string& ice_ufrag, 54 virtual void SetRemoteIceCredentials(const std::string& ice_ufrag,
55 const std::string& ice_pwd) = 0; 55 const std::string& ice_pwd) = 0;
56 56
57 // SetRemoteIceMode must be implemented only by the ICE transport channels. 57 // SetRemoteIceMode must be implemented only by the ICE transport channels.
58 virtual void SetRemoteIceMode(IceMode mode) = 0; 58 virtual void SetRemoteIceMode(IceMode mode) = 0;
59 59
60 virtual void SetIceConfig(const IceConfig& config) = 0; 60 virtual void SetIceConfig(const IceConfig& config) = 0;
61 61
62 // Begins the process of attempting to make a connection to the other client.
63 virtual void Connect() = 0;
64
65 // Start gathering candidates if not already started, or if an ICE restart 62 // Start gathering candidates if not already started, or if an ICE restart
66 // occurred. 63 // occurred.
67 virtual void MaybeStartGathering() = 0; 64 virtual void MaybeStartGathering() = 0;
68 65
69 sigslot::signal1<TransportChannelImpl*> SignalGatheringState; 66 sigslot::signal1<TransportChannelImpl*> SignalGatheringState;
70 67
71 // Handles sending and receiving of candidates. The Transport 68 // Handles sending and receiving of candidates. The Transport
72 // receives the candidates and may forward them to the relevant 69 // receives the candidates and may forward them to the relevant
73 // channel. 70 // channel.
74 // 71 //
(...skipping 28 matching lines...) Expand all
103 // Emitted whenever the transport channel state changed. 100 // Emitted whenever the transport channel state changed.
104 sigslot::signal1<TransportChannelImpl*> SignalStateChanged; 101 sigslot::signal1<TransportChannelImpl*> SignalStateChanged;
105 102
106 private: 103 private:
107 RTC_DISALLOW_COPY_AND_ASSIGN(TransportChannelImpl); 104 RTC_DISALLOW_COPY_AND_ASSIGN(TransportChannelImpl);
108 }; 105 };
109 106
110 } // namespace cricket 107 } // namespace cricket
111 108
112 #endif // WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_ 109 #endif // WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_
OLDNEW
« no previous file with comments | « webrtc/p2p/base/transport_unittest.cc ('k') | webrtc/p2p/base/transportcontroller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698