Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2099483002: Add native handle support to SimulcastEncoderAdapter. (Closed)

Created:
4 years, 6 months ago by noahric
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman, wuchengli
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add native handle support to SimulcastEncoderAdapter. If all subencoders support textures, the adapter will claim support. Texture frames will be passed on directly to subencoders, without any attempt at scaling, and subencoders will be expected to sample/scale correctly from source textures. BUG= NOTRY=true Committed: https://crrev.com/fe3654d5dceb3d931cd773afae511e90180d39ba Cr-Commit-Position: refs/heads/master@{#13365}

Patch Set 1 #

Patch Set 2 : Merged with ToT #

Total comments: 6

Patch Set 3 : Add a comment and remove some brackets. #

Patch Set 4 : git pull #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -22 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 1 2 2 chunks +14 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc View 1 5 chunks +48 lines, -15 lines 0 comments Download

Messages

Total messages: 45 (18 generated)
noahric
Let me know if this looks ok.
4 years, 6 months ago (2016-06-23 21:19:58 UTC) #2
pbos-webrtc
magjed@, PTAL, specifically: Do the native handles support scaling (applying a matrix) that should be ...
4 years, 5 months ago (2016-06-26 21:36:46 UTC) #4
perkj_webrtc
emirican - is this cl a problem currently on Mac and Win for hw codecs ...
4 years, 5 months ago (2016-06-27 08:02:01 UTC) #6
emircan
On 2016/06/27 08:02:01, perkj_webrtc_ooo_june20 wrote: > emirican - is this cl a problem currently on ...
4 years, 5 months ago (2016-06-27 18:53:26 UTC) #7
noahric
On 2016/06/27 18:53:26, emircan wrote: > On 2016/06/27 08:02:01, perkj_webrtc_ooo_june20 wrote: > > emirican - ...
4 years, 5 months ago (2016-06-27 19:26:02 UTC) #8
noahric
+zeke: have you played around with the pixelbuffer input mode for iOS hardware h264 encode? ...
4 years, 5 months ago (2016-06-27 19:28:11 UTC) #10
noahric
On 2016/06/27 19:26:02, noahric wrote: > On 2016/06/27 18:53:26, emircan wrote: > > On 2016/06/27 ...
4 years, 5 months ago (2016-06-27 19:29:09 UTC) #11
tkchin_webrtc
On 2016/06/27 19:29:09, noahric wrote: > On 2016/06/27 19:26:02, noahric wrote: > > On 2016/06/27 ...
4 years, 5 months ago (2016-06-27 21:46:35 UTC) #12
noahric
On 2016/06/27 21:46:35, tkchin_webrtc wrote: > On 2016/06/27 19:29:09, noahric wrote: > > On 2016/06/27 ...
4 years, 5 months ago (2016-06-27 22:56:27 UTC) #13
perkj_webrtc
lgtm https://codereview.webrtc.org/2099483002/diff/20001/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc File webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc (right): https://codereview.webrtc.org/2099483002/diff/20001/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc#newcode306 webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc:306: VideoFrame dst_frame; So apparently no one use simulcast ...
4 years, 5 months ago (2016-06-28 14:09:00 UTC) #14
pbos-webrtc
+wuchengli@, I believe RTCVideoEncoder on ChromeOS can use textures. So I think this might break ...
4 years, 5 months ago (2016-06-28 14:12:05 UTC) #16
wuchengli1
On 2016/06/28 14:12:05, pbos-webrtc wrote: > +wuchengli@, I believe RTCVideoEncoder on ChromeOS can use textures. ...
4 years, 5 months ago (2016-06-28 14:31:38 UTC) #17
noahric
> What does it mean that the quality scaler want to downscale a layer due ...
4 years, 5 months ago (2016-06-28 17:32:40 UTC) #18
magjed_webrtc
On 2016/06/28 17:32:40, noahric wrote: > They are scaled in the android implementation, though it's ...
4 years, 5 months ago (2016-06-29 09:35:54 UTC) #19
perkj_webrtc
On 2016/06/28 17:32:40, noahric wrote: > > What does it mean that the quality scaler ...
4 years, 5 months ago (2016-06-29 13:29:52 UTC) #20
pbos-webrtc
lgtm https://codereview.webrtc.org/2099483002/diff/20001/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc File webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc (right): https://codereview.webrtc.org/2099483002/diff/20001/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc#newcode306 webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc:306: VideoFrame dst_frame; On 2016/06/28 14:09:00, perkj_webrtc_ooo_june20 wrote: > ...
4 years, 5 months ago (2016-06-29 15:48:27 UTC) #23
noahric
https://codereview.webrtc.org/2099483002/diff/20001/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc File webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc (right): https://codereview.webrtc.org/2099483002/diff/20001/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc#newcode299 webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc:299: input_image.video_frame_buffer()->native_handle()) { On 2016/06/27 08:02:01, perkj_webrtc_ooo_june20 wrote: > The ...
4 years, 5 months ago (2016-06-30 17:17:40 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2099483002/60001
4 years, 5 months ago (2016-06-30 20:02:10 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14708)
4 years, 5 months ago (2016-06-30 20:09:01 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2099483002/60001
4 years, 5 months ago (2016-06-30 22:52:44 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14716)
4 years, 5 months ago (2016-06-30 22:59:15 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2099483002/60001
4 years, 5 months ago (2016-07-01 00:15:21 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14718)
4 years, 5 months ago (2016-07-01 00:19:36 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2099483002/60001
4 years, 5 months ago (2016-07-01 16:02:40 UTC) #40
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-01 16:06:00 UTC) #42
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 16:06:05 UTC) #43
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 16:06:10 UTC) #45
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fe3654d5dceb3d931cd773afae511e90180d39ba
Cr-Commit-Position: refs/heads/master@{#13365}

Powered by Google App Engine
This is Rietveld 408576698