webrtc/modules/rtp_rtcp/source/producer_fec.h - Issue 2099243003: Use std::unique_ptr in ForwardErrorCorrection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/producer_fec.h

Issue 2099243003: Use std::unique_ptr in ForwardErrorCorrection. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@flexfec-pt1a_mini-fixes-in-ULPFEC

Patch Set: Final nit from danilchap. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/rtp_rtcp/source/forward_error_correction.cc ('K') | « webrtc/modules/rtp_rtcp/source/forward_error_correction.cc ('k') | webrtc/modules/rtp_rtcp/source/producer_fec.cc » ('j') | webrtc/modules/rtp_rtcp/source/rtp_fec_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/producer_fec.h

diff --git a/webrtc/modules/rtp_rtcp/source/producer_fec.h b/webrtc/modules/rtp_rtcp/source/producer_fec.h

index 063a45fa95b79a948ada1c27c72f94b6264f7c77..fc2e8e4a8a0fc43e9e985fd8bde2ebfa1d2828ae 100644

--- a/webrtc/modules/rtp_rtcp/source/producer_fec.h

+++ b/webrtc/modules/rtp_rtcp/source/producer_fec.h

@@ -11,6 +11,7 @@

#ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_PRODUCER_FEC_H_

#define WEBRTC_MODULES_RTP_RTCP_SOURCE_PRODUCER_FEC_H_

+#include <list>

#include <vector>

#include "webrtc/modules/rtp_rtcp/source/forward_error_correction.h"

@@ -72,7 +73,7 @@ class ProducerFec {

int Overhead() const;

ForwardErrorCorrection* fec_;

ForwardErrorCorrection::PacketList media_packets_fec_;

- ForwardErrorCorrection::PacketList fec_packets_;

+ std::list<ForwardErrorCorrection::Packet*> fec_packets_;

int num_frames_;

int num_first_partition_;

int minimum_media_packets_fec_;