Use std::unique_ptr in ForwardErrorCorrection.

webrtc/modules/rtp_rtcp/source/fec_receiver_impl.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 11 matching lines @@
 
 FecReceiver* FecReceiver::Create(RtpData* callback) {
   return new FecReceiverImpl(callback);
 }
 
 FecReceiverImpl::FecReceiverImpl(RtpData* callback)
     : recovered_packet_callback_(callback),
       fec_(new ForwardErrorCorrection()) {}
 
 FecReceiverImpl::~FecReceiverImpl() {
-  while (!received_packet_list_.empty()) {
-    delete received_packet_list_.front();
-    received_packet_list_.pop_front();
-  }
+  received_packet_list_.clear();
   if (fec_ != NULL) {
     fec_->ResetState(&recovered_packet_list_);
     delete fec_;
   }
 }
 
 FecPacketCounter FecReceiverImpl::GetPacketCounter() const {
   rtc::CritScope cs(&crit_sect_);
   return packet_counter_;
 }
@@ skipping 156 matching lines @@
         payload_data_length - REDHeaderLength);
 
     received_packet->pkt->length =
         header.headerLength + payload_data_length - REDHeaderLength;
   }
 
   if (received_packet->pkt->length == 0) {
     return 0;
   }
 
-  received_packet_list_.push_back(received_packet.release());
+  received_packet_list_.push_back(std::move(received_packet));
   if (second_received_packet) {
-    received_packet_list_.push_back(second_received_packet.release());
+    received_packet_list_.push_back(std::move(second_received_packet));
   }
   return 0;
 }
 
 int32_t FecReceiverImpl::ProcessReceivedFec() {
   crit_sect_.Enter();
   if (!received_packet_list_.empty()) {
     // Send received media packet to VCM.
     if (!received_packet_list_.front()->is_fec) {
       ForwardErrorCorrection::Packet* packet =
           received_packet_list_.front()->pkt;
       crit_sect_.Leave();
       if (!recovered_packet_callback_->OnRecoveredPacket(packet->data,
                                                          packet->length)) {
         return -1;
       }
       crit_sect_.Enter();
     }
     if (fec_->DecodeFec(&received_packet_list_, &recovered_packet_list_) != 0) {
       crit_sect_.Leave();
       return -1;
     }
     RTC_DCHECK(received_packet_list_.empty());
   }
   // Send any recovered media packets to VCM.
-  for(auto* recovered_packet : recovered_packet_list_) {
+  for(auto& recovered_packet : recovered_packet_list_) {

[stefan-webrtc, 2016/07/05 08:51:38]

for (const auto&

[brandtr, 2016/07/05 10:28:00]

Done.

     if (recovered_packet->returned) {
       // Already sent to the VCM and the jitter buffer.
       continue;
     }
     ForwardErrorCorrection::Packet* packet = recovered_packet->pkt;
     ++packet_counter_.num_recovered_packets;
     crit_sect_.Leave();
     if (!recovered_packet_callback_->OnRecoveredPacket(packet->data,
                                                        packet->length)) {
       return -1;
     }
     crit_sect_.Enter();
     recovered_packet->returned = true;
   }
   crit_sect_.Leave();
   return 0;
 }
 
 }  // namespace webrtc