Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2098703004: Revert of Revert "Revert of Update the BWE when the network route changes. (patchset #5 id:180001 of https://… (Closed)

Created:
4 years, 6 months ago by honghaiz3
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, zhuangzesen_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Revert "Revert of Update the BWE when the network route changes. (patchset #5 id:180001 of https://… (patchset #5 id:120001 of https://codereview.webrtc.org/2041593002/ ) Reason for revert: ReadyToSendMedia did not consider the new presumed_writable state. Original issue's description: > Revert "Revert of Update the BWE when the network route changes. (patchset #5 id:180001 of https://codereview.webrtc.org/2000063003/ )" > > This reverts commit 72d41aa6da94dacb8a8464d1abd4ca7d1afffc65. > > New change made: > Do not reset the BWE when the new network route is not ready to send media. > > BUG= > R=pthatcher@webrtc.org, stefan@webrtc.org > > Committed: https://crrev.com/5b5d2cdad7018993272525a723ef34f7da5c45f2 > Cr-Commit-Position: refs/heads/master@{#13280} TBR=pthatcher@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/ae4d0d922ba15075116571e048d3aebe9d501b49 Cr-Commit-Position: refs/heads/master@{#13281}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -102 lines) Patch
M webrtc/base/networkroute.h View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/call/call.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/bitrate_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/mock/mock_bitrate_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 3 chunks +12 lines, -39 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/p2p/base/candidatepairinterface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/p2p/base/port.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/p2p/base/port.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/channel.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/pc/channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
honghaiz3
Created Revert of Revert "Revert of Update the BWE when the network route changes. (patchset ...
4 years, 6 months ago (2016-06-24 17:05:58 UTC) #2
honghaiz3
4 years, 6 months ago (2016-06-24 17:50:46 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2094863003/ by honghaiz@webrtc.org.

The reason for reverting is: It turns out this revert was not necessary because
the connection-state mapping for turn-turn connections was not done in
connection. .

Powered by Google App Engine
This is Rietveld 408576698