Add virtual Initialize methods to PortAllocator and NetworkManager.

Add virtual Initialize methods to PortAllocator and NetworkManager.

This will allow PeerConnection to handle hopping to the right thread
and doing thread-specific initialization for the PortAllocator.
This eliminates a required thread-hop for whatever is passing the
PortAllocator into CreatePeerConnection.

BUG=617648
R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed: https://crrev.com/f8e65779a7dc890d8d6f38eca50985a2f0407da1
Committed: https://crrev.com/a6bdb0990a659ff9e7c4374f5033a6bcc4fbfb21
Cr-Original-Commit-Position: refs/heads/master@{#13283}
Cr-Commit-Position: refs/heads/master@{#13306}

[Taylor Brandstetter, 2016-06-23 20:21:01]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org, skvlad@webrtc.org

[Taylor Brandstetter, 2016-06-23 20:21:03]

Please take a look. This allows us to eliminate a thread hop and race condition
for Chrome when creating a PeerConnection, so good stuff all around.

[pthatcher1, 2016-06-23 22:01:59]

https://codereview.webrtc.org/2097653002/diff/1/webrtc/base/network.h
File webrtc/base/network.h (right):

https://codereview.webrtc.org/2097653002/diff/1/webrtc/base/network.h#newcode68
webrtc/base/network.h:68: // (including the destructor) should be called on a
different thread.
This makes it sound like it must be constructed and used on different threads. 
But what I think you mean to say is that it must be used only on one thread, but
that thread can be different than the thread it's constructed on.  Is that
right?

[skvlad, 2016-06-23 22:15:55]

lgtm

https://codereview.webrtc.org/2097653002/diff/1/webrtc/p2p/base/portallocator.h
File webrtc/p2p/base/portallocator.h (right):

https://codereview.webrtc.org/2097653002/diff/1/webrtc/p2p/base/portallocator...
webrtc/p2p/base/portallocator.h:225: // (including the destructor) should be
called on a different thread.
Do we have a way to verify that the "other thread" is always the same? like a
lazily initialized version of the ThreadChecker? 
It'd be good if we can enforce that requirement.

[Taylor Brandstetter, 2016-06-23 22:59:07]

https://codereview.webrtc.org/2097653002/diff/1/webrtc/base/network.h
File webrtc/base/network.h (right):

https://codereview.webrtc.org/2097653002/diff/1/webrtc/base/network.h#newcode68
webrtc/base/network.h:68: // (including the destructor) should be called on a
different thread.
On 2016/06/23 22:01:59, pthatcher1 wrote:
> This makes it sound like it must be constructed and used on different threads.

> But what I think you mean to say is that it must be used only on one thread,
but
> that thread can be different than the thread it's constructed on.  Is that
> right?

Good catch. Just a situation where my brain was working faster than my fingers.
I mean to say "on the same thread" here and "on a different thread" below but I
accidentally typed the latter in both places.

https://codereview.webrtc.org/2097653002/diff/1/webrtc/p2p/base/portallocator.h
File webrtc/p2p/base/portallocator.h (right):

https://codereview.webrtc.org/2097653002/diff/1/webrtc/p2p/base/portallocator...
webrtc/p2p/base/portallocator.h:225: // (including the destructor) should be
called on a different thread.
On 2016/06/23 22:15:55, skvlad wrote:
> Do we have a way to verify that the "other thread" is always the same? like a
> lazily initialized version of the ThreadChecker? 
> It'd be good if we can enforce that requirement.

Yeah, we can call "DetachFromThread" in the constructor so that it's attached
when the next method is called. This is the pattern Chrome uses. However...
Chrome currently still calls some methods from the wrong thread. I'll add the
thread checking once Chrome starts relying on Initialize, which will fix that.

[pthatcher1, 2016-06-23 23:41:36]

https://codereview.webrtc.org/2097653002/diff/20001/webrtc/base/network.h
File webrtc/base/network.h (right):

https://codereview.webrtc.org/2097653002/diff/20001/webrtc/base/network.h#new...
webrtc/base/network.h:68: // (including the destructor) should be called on the
same thread.
Now it sounds like it should be on the same thread as the constructor thread. 
Perhaps just add "(which thread may be different than the thread its constructed
on)".

[Taylor Brandstetter, 2016-06-24 00:43:07]

https://codereview.webrtc.org/2097653002/diff/20001/webrtc/base/network.h
File webrtc/base/network.h (right):

https://codereview.webrtc.org/2097653002/diff/20001/webrtc/base/network.h#new...
webrtc/base/network.h:68: // (including the destructor) should be called on the
same thread.
On 2016/06/23 23:41:35, pthatcher1 wrote:
> Now it sounds like it should be on the same thread as the constructor thread. 
> Perhaps just add "(which thread may be different than the thread its
constructed
> on)".

Given the word "but" and the sentence below I think the meaning is clear enough.
But I revised it again, take a look...

[pthatcher1, 2016-06-24 00:46:13]

lgtm

[Taylor Brandstetter, 2016-06-24 21:04:11]

Description was changed from

==========
Add virtual Initialize methods to PortAllocator and NetworkManager.

This will allow PeerConnection to handle hopping to the right thread
and doing thread-specific initialization for the PortAllocator.
This eliminates a required thread-hop for whatever is passing the
PortAllocator into CreatePeerConnection.

BUG=617648
==========

to

==========
Add virtual Initialize methods to PortAllocator and NetworkManager.

This will allow PeerConnection to handle hopping to the right thread
and doing thread-specific initialization for the PortAllocator.
This eliminates a required thread-hop for whatever is passing the
PortAllocator into CreatePeerConnection.

BUG=617648
R=pthatcher@webrtc.org, skvlad@webrtc.org
==========

[Taylor Brandstetter, 2016-06-24 21:04:13]

Committed patchset #4 (id:60001) to pending queue manually as
a17abdb48efcbe636c5bbbe1ac6d3a1fe8254742 (presubmit successful).

[commit-bot: I haz the power, 2016-06-24 21:04:17]

Description was changed from

==========
Add virtual Initialize methods to PortAllocator and NetworkManager.

This will allow PeerConnection to handle hopping to the right thread
and doing thread-specific initialization for the PortAllocator.
This eliminates a required thread-hop for whatever is passing the
PortAllocator into CreatePeerConnection.

BUG=617648
R=pthatcher@webrtc.org, skvlad@webrtc.org
==========

to

==========
Add virtual Initialize methods to PortAllocator and NetworkManager.

This will allow PeerConnection to handle hopping to the right thread
and doing thread-specific initialization for the PortAllocator.
This eliminates a required thread-hop for whatever is passing the
PortAllocator into CreatePeerConnection.

BUG=617648
R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed: https://crrev.com/a6bdb0990a659ff9e7c4374f5033a6bcc4fbfb21
Cr-Commit-Position: refs/heads/master@{#13283}
==========

[commit-bot: I haz the power, 2016-06-24 21:04:18]

Patchset 4 (id:??) landed as
https://crrev.com/a6bdb0990a659ff9e7c4374f5033a6bcc4fbfb21
Cr-Commit-Position: refs/heads/master@{#13283}

[Taylor Brandstetter, 2016-06-24 21:04:49]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.webrtc.org/2092023004/ by deadbeef@webrtc.org.

The reason for reverting is: Didn't intend to land yet. Chromium CL still
needed..

[Taylor Brandstetter, 2016-06-24 21:05:13]

Description was changed from

==========
Add virtual Initialize methods to PortAllocator and NetworkManager.

This will allow PeerConnection to handle hopping to the right thread
and doing thread-specific initialization for the PortAllocator.
This eliminates a required thread-hop for whatever is passing the
PortAllocator into CreatePeerConnection.

BUG=617648
R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed: https://crrev.com/a6bdb0990a659ff9e7c4374f5033a6bcc4fbfb21
Cr-Commit-Position: refs/heads/master@{#13283}
==========

to

==========
Add virtual Initialize methods to PortAllocator and NetworkManager.

This will allow PeerConnection to handle hopping to the right thread
and doing thread-specific initialization for the PortAllocator.
This eliminates a required thread-hop for whatever is passing the
PortAllocator into CreatePeerConnection.

BUG=617648
R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed: https://crrev.com/a6bdb0990a659ff9e7c4374f5033a6bcc4fbfb21
Cr-Commit-Position: refs/heads/master@{#13283}
==========

[Taylor Brandstetter, 2016-06-28 00:20:30]

Description was changed from

==========
Add virtual Initialize methods to PortAllocator and NetworkManager.

This will allow PeerConnection to handle hopping to the right thread
and doing thread-specific initialization for the PortAllocator.
This eliminates a required thread-hop for whatever is passing the
PortAllocator into CreatePeerConnection.

BUG=617648
R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed: https://crrev.com/a6bdb0990a659ff9e7c4374f5033a6bcc4fbfb21
Cr-Commit-Position: refs/heads/master@{#13283}
==========

to

==========
Add virtual Initialize methods to PortAllocator and NetworkManager.

This will allow PeerConnection to handle hopping to the right thread
and doing thread-specific initialization for the PortAllocator.
This eliminates a required thread-hop for whatever is passing the
PortAllocator into CreatePeerConnection.

BUG=617648
R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed: https://crrev.com/a6bdb0990a659ff9e7c4374f5033a6bcc4fbfb21
Cr-Commit-Position: refs/heads/master@{#13283}
Committed:
https://chromium.googlesource.com/external/webrtc/+/f8e65779a7dc890d8d6f38eca...
==========

[Taylor Brandstetter, 2016-06-28 00:20:32]

Committed patchset #5 (id:80001) manually as
f8e65779a7dc890d8d6f38eca50985a2f0407da1 (presubmit successful).

[commit-bot: I haz the power, 2016-06-28 00:20:35]

Description was changed from

==========
Add virtual Initialize methods to PortAllocator and NetworkManager.

This will allow PeerConnection to handle hopping to the right thread
and doing thread-specific initialization for the PortAllocator.
This eliminates a required thread-hop for whatever is passing the
PortAllocator into CreatePeerConnection.

BUG=617648
R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed: https://crrev.com/a6bdb0990a659ff9e7c4374f5033a6bcc4fbfb21
Cr-Commit-Position: refs/heads/master@{#13283}
Committed:
https://chromium.googlesource.com/external/webrtc/+/f8e65779a7dc890d8d6f38eca...
==========

to

==========
Add virtual Initialize methods to PortAllocator and NetworkManager.

This will allow PeerConnection to handle hopping to the right thread
and doing thread-specific initialization for the PortAllocator.
This eliminates a required thread-hop for whatever is passing the
PortAllocator into CreatePeerConnection.

BUG=617648
R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed: https://crrev.com/f8e65779a7dc890d8d6f38eca50985a2f0407da1
Committed: https://crrev.com/a6bdb0990a659ff9e7c4374f5033a6bcc4fbfb21
Cr-Original-Commit-Position: refs/heads/master@{#13283}
Cr-Commit-Position: refs/heads/master@{#13306}
==========