Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: webrtc/common_video/incoming_video_stream.cc

Issue 2097403002: Add a race-checking mechanism. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/common_video/include/incoming_video_stream.h ('k') | webrtc/modules/video_coding/generic_encoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/common_video/incoming_video_stream.cc
diff --git a/webrtc/common_video/incoming_video_stream.cc b/webrtc/common_video/incoming_video_stream.cc
index f5a52fcba335f25d1a1a7b7d53773d519d3aec5f..c6b638686f3ae8ad18f5b2e3fafc208cc30c9e84 100644
--- a/webrtc/common_video/incoming_video_stream.cc
+++ b/webrtc/common_video/incoming_video_stream.cc
@@ -49,9 +49,7 @@ IncomingVideoStream::~IncomingVideoStream() {
}
void IncomingVideoStream::OnFrame(const VideoFrame& video_frame) {
- // Most of the time we'll be on a decoder thread here, but when using
- // VideoToolbox on iOS, we'll get called on a thread from a thread pool.
-
+ RTC_CHECK_RUNS_SINGLE_THREADED(&decoder_race_checker_);
pbos-webrtc 2016/06/27 14:07:59 This is a CHECK (not a DCHECK) because we have man
// Hand over or insert frame.
rtc::CritScope csB(&buffer_critsect_);
if (render_buffers_->AddFrame(video_frame) == 1) {
« no previous file with comments | « webrtc/common_video/include/incoming_video_stream.h ('k') | webrtc/modules/video_coding/generic_encoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698