Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2097363002: Make mixing test die earlier on failure instead of spamming errors (Closed)

Created:
4 years, 5 months ago by phoglund
Modified:
4 years, 5 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make mixing test die earlier on failure instead of spamming errors This test currently takes 288 seconds to fail if output values are wrong; there's no point to print the failure hundreds of times. This change will exit the test early. R=henrika@webrtc.org BUG=623538 NOTRY=true Committed: https://crrev.com/685440be2dd3bcb996babfcd4ee31b8b71100436 Cr-Commit-Position: refs/heads/master@{#13295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/voice_engine/test/auto_test/standard/mixing_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
phoglund
4 years, 5 months ago (2016-06-27 12:55:16 UTC) #1
henrika_webrtc
LGTM
4 years, 5 months ago (2016-06-27 13:12:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2097363002/1
4 years, 5 months ago (2016-06-27 14:16:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 14:18:39 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 14:18:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/685440be2dd3bcb996babfcd4ee31b8b71100436
Cr-Commit-Position: refs/heads/master@{#13295}

Powered by Google App Engine
This is Rietveld 408576698