Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: webrtc/api/localaudiosource.cc

Issue 2095563002: Adding activation logic of the new APM level control functionality using MediaConstraints (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@ALC_RC2_CL
Patch Set: Changed logging behavior according to reviewer comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/mediaconstraintsinterface.h » ('j') | webrtc/media/engine/webrtcvoiceengine.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/localaudiosource.cc
diff --git a/webrtc/api/localaudiosource.cc b/webrtc/api/localaudiosource.cc
index 9da9fd2612316c384100ee6faf8ac6a773f60500..799fe7209ffb5c280d738d76a566ed0f165b36fc 100644
--- a/webrtc/api/localaudiosource.cc
+++ b/webrtc/api/localaudiosource.cc
@@ -49,11 +49,11 @@ void FromConstraints(const MediaConstraintsInterface::Constraints& constraints,
options->experimental_ns},
{MediaConstraintsInterface::kIntelligibilityEnhancer,
options->intelligibility_enhancer},
+ {MediaConstraintsInterface::kLevelControl, options->level_control},
{MediaConstraintsInterface::kHighpassFilter, options->highpass_filter},
{MediaConstraintsInterface::kTypingNoiseDetection,
options->typing_detection},
- {MediaConstraintsInterface::kAudioMirroring, options->stereo_swapping}
- };
+ {MediaConstraintsInterface::kAudioMirroring, options->stereo_swapping}};
hlundin-webrtc 2016/06/27 11:44:27 I presume clang-format gave you this, but in this
peah-webrtc 2016/06/27 23:00:05 Yes, that was clang-format, and I definitely agree
for (const auto& constraint : constraints) {
bool value = false;
« no previous file with comments | « no previous file | webrtc/api/mediaconstraintsinterface.h » ('j') | webrtc/media/engine/webrtcvoiceengine.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698