Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: webrtc/media/base/mediachannel.h

Issue 2095563002: Adding activation logic of the new APM level control functionality using MediaConstraints (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@ALC_RC2_CL
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/mediaconstraintsinterface.cc ('k') | webrtc/media/engine/webrtcvoiceengine.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 SetFrom(&audio_jitter_buffer_fast_accelerate, 151 SetFrom(&audio_jitter_buffer_fast_accelerate,
152 change.audio_jitter_buffer_fast_accelerate); 152 change.audio_jitter_buffer_fast_accelerate);
153 SetFrom(&typing_detection, change.typing_detection); 153 SetFrom(&typing_detection, change.typing_detection);
154 SetFrom(&aecm_generate_comfort_noise, change.aecm_generate_comfort_noise); 154 SetFrom(&aecm_generate_comfort_noise, change.aecm_generate_comfort_noise);
155 SetFrom(&adjust_agc_delta, change.adjust_agc_delta); 155 SetFrom(&adjust_agc_delta, change.adjust_agc_delta);
156 SetFrom(&experimental_agc, change.experimental_agc); 156 SetFrom(&experimental_agc, change.experimental_agc);
157 SetFrom(&extended_filter_aec, change.extended_filter_aec); 157 SetFrom(&extended_filter_aec, change.extended_filter_aec);
158 SetFrom(&delay_agnostic_aec, change.delay_agnostic_aec); 158 SetFrom(&delay_agnostic_aec, change.delay_agnostic_aec);
159 SetFrom(&experimental_ns, change.experimental_ns); 159 SetFrom(&experimental_ns, change.experimental_ns);
160 SetFrom(&intelligibility_enhancer, change.intelligibility_enhancer); 160 SetFrom(&intelligibility_enhancer, change.intelligibility_enhancer);
161 SetFrom(&level_control, change.level_control);
161 SetFrom(&tx_agc_target_dbov, change.tx_agc_target_dbov); 162 SetFrom(&tx_agc_target_dbov, change.tx_agc_target_dbov);
162 SetFrom(&tx_agc_digital_compression_gain, 163 SetFrom(&tx_agc_digital_compression_gain,
163 change.tx_agc_digital_compression_gain); 164 change.tx_agc_digital_compression_gain);
164 SetFrom(&tx_agc_limiter, change.tx_agc_limiter); 165 SetFrom(&tx_agc_limiter, change.tx_agc_limiter);
165 SetFrom(&recording_sample_rate, change.recording_sample_rate); 166 SetFrom(&recording_sample_rate, change.recording_sample_rate);
166 SetFrom(&playout_sample_rate, change.playout_sample_rate); 167 SetFrom(&playout_sample_rate, change.playout_sample_rate);
167 SetFrom(&combined_audio_video_bwe, change.combined_audio_video_bwe); 168 SetFrom(&combined_audio_video_bwe, change.combined_audio_video_bwe);
168 } 169 }
169 170
170 bool operator==(const AudioOptions& o) const { 171 bool operator==(const AudioOptions& o) const {
171 return echo_cancellation == o.echo_cancellation && 172 return echo_cancellation == o.echo_cancellation &&
172 auto_gain_control == o.auto_gain_control && 173 auto_gain_control == o.auto_gain_control &&
173 noise_suppression == o.noise_suppression && 174 noise_suppression == o.noise_suppression &&
174 highpass_filter == o.highpass_filter && 175 highpass_filter == o.highpass_filter &&
175 stereo_swapping == o.stereo_swapping && 176 stereo_swapping == o.stereo_swapping &&
176 audio_jitter_buffer_max_packets == o.audio_jitter_buffer_max_packets && 177 audio_jitter_buffer_max_packets ==
177 audio_jitter_buffer_fast_accelerate == 178 o.audio_jitter_buffer_max_packets &&
178 o.audio_jitter_buffer_fast_accelerate && 179 audio_jitter_buffer_fast_accelerate ==
179 typing_detection == o.typing_detection && 180 o.audio_jitter_buffer_fast_accelerate &&
180 aecm_generate_comfort_noise == o.aecm_generate_comfort_noise && 181 typing_detection == o.typing_detection &&
181 experimental_agc == o.experimental_agc && 182 aecm_generate_comfort_noise == o.aecm_generate_comfort_noise &&
182 extended_filter_aec == o.extended_filter_aec && 183 experimental_agc == o.experimental_agc &&
183 delay_agnostic_aec == o.delay_agnostic_aec && 184 extended_filter_aec == o.extended_filter_aec &&
184 experimental_ns == o.experimental_ns && 185 delay_agnostic_aec == o.delay_agnostic_aec &&
185 intelligibility_enhancer == o.intelligibility_enhancer && 186 experimental_ns == o.experimental_ns &&
186 adjust_agc_delta == o.adjust_agc_delta && 187 intelligibility_enhancer == o.intelligibility_enhancer &&
187 tx_agc_target_dbov == o.tx_agc_target_dbov && 188 level_control == o.level_control &&
188 tx_agc_digital_compression_gain == o.tx_agc_digital_compression_gain && 189 adjust_agc_delta == o.adjust_agc_delta &&
189 tx_agc_limiter == o.tx_agc_limiter && 190 tx_agc_target_dbov == o.tx_agc_target_dbov &&
190 recording_sample_rate == o.recording_sample_rate && 191 tx_agc_digital_compression_gain ==
191 playout_sample_rate == o.playout_sample_rate && 192 o.tx_agc_digital_compression_gain &&
192 combined_audio_video_bwe == o.combined_audio_video_bwe; 193 tx_agc_limiter == o.tx_agc_limiter &&
194 recording_sample_rate == o.recording_sample_rate &&
195 playout_sample_rate == o.playout_sample_rate &&
196 combined_audio_video_bwe == o.combined_audio_video_bwe;
193 } 197 }
194 bool operator!=(const AudioOptions& o) const { return !(*this == o); } 198 bool operator!=(const AudioOptions& o) const { return !(*this == o); }
195 199
196 std::string ToString() const { 200 std::string ToString() const {
197 std::ostringstream ost; 201 std::ostringstream ost;
198 ost << "AudioOptions {"; 202 ost << "AudioOptions {";
199 ost << ToStringIfSet("aec", echo_cancellation); 203 ost << ToStringIfSet("aec", echo_cancellation);
200 ost << ToStringIfSet("agc", auto_gain_control); 204 ost << ToStringIfSet("agc", auto_gain_control);
201 ost << ToStringIfSet("ns", noise_suppression); 205 ost << ToStringIfSet("ns", noise_suppression);
202 ost << ToStringIfSet("hf", highpass_filter); 206 ost << ToStringIfSet("hf", highpass_filter);
203 ost << ToStringIfSet("swap", stereo_swapping); 207 ost << ToStringIfSet("swap", stereo_swapping);
204 ost << ToStringIfSet("audio_jitter_buffer_max_packets", 208 ost << ToStringIfSet("audio_jitter_buffer_max_packets",
205 audio_jitter_buffer_max_packets); 209 audio_jitter_buffer_max_packets);
206 ost << ToStringIfSet("audio_jitter_buffer_fast_accelerate", 210 ost << ToStringIfSet("audio_jitter_buffer_fast_accelerate",
207 audio_jitter_buffer_fast_accelerate); 211 audio_jitter_buffer_fast_accelerate);
208 ost << ToStringIfSet("typing", typing_detection); 212 ost << ToStringIfSet("typing", typing_detection);
209 ost << ToStringIfSet("comfort_noise", aecm_generate_comfort_noise); 213 ost << ToStringIfSet("comfort_noise", aecm_generate_comfort_noise);
210 ost << ToStringIfSet("agc_delta", adjust_agc_delta); 214 ost << ToStringIfSet("agc_delta", adjust_agc_delta);
211 ost << ToStringIfSet("experimental_agc", experimental_agc); 215 ost << ToStringIfSet("experimental_agc", experimental_agc);
212 ost << ToStringIfSet("extended_filter_aec", extended_filter_aec); 216 ost << ToStringIfSet("extended_filter_aec", extended_filter_aec);
213 ost << ToStringIfSet("delay_agnostic_aec", delay_agnostic_aec); 217 ost << ToStringIfSet("delay_agnostic_aec", delay_agnostic_aec);
214 ost << ToStringIfSet("experimental_ns", experimental_ns); 218 ost << ToStringIfSet("experimental_ns", experimental_ns);
215 ost << ToStringIfSet("intelligibility_enhancer", intelligibility_enhancer); 219 ost << ToStringIfSet("intelligibility_enhancer", intelligibility_enhancer);
220 ost << ToStringIfSet("level_control", level_control);
216 ost << ToStringIfSet("tx_agc_target_dbov", tx_agc_target_dbov); 221 ost << ToStringIfSet("tx_agc_target_dbov", tx_agc_target_dbov);
217 ost << ToStringIfSet("tx_agc_digital_compression_gain", 222 ost << ToStringIfSet("tx_agc_digital_compression_gain",
218 tx_agc_digital_compression_gain); 223 tx_agc_digital_compression_gain);
219 ost << ToStringIfSet("tx_agc_limiter", tx_agc_limiter); 224 ost << ToStringIfSet("tx_agc_limiter", tx_agc_limiter);
220 ost << ToStringIfSet("recording_sample_rate", recording_sample_rate); 225 ost << ToStringIfSet("recording_sample_rate", recording_sample_rate);
221 ost << ToStringIfSet("playout_sample_rate", playout_sample_rate); 226 ost << ToStringIfSet("playout_sample_rate", playout_sample_rate);
222 ost << ToStringIfSet("combined_audio_video_bwe", combined_audio_video_bwe); 227 ost << ToStringIfSet("combined_audio_video_bwe", combined_audio_video_bwe);
223 ost << "}"; 228 ost << "}";
224 return ost.str(); 229 return ost.str();
225 } 230 }
(...skipping 15 matching lines...) Expand all
241 rtc::Optional<bool> audio_jitter_buffer_fast_accelerate; 246 rtc::Optional<bool> audio_jitter_buffer_fast_accelerate;
242 // Audio processing to detect typing. 247 // Audio processing to detect typing.
243 rtc::Optional<bool> typing_detection; 248 rtc::Optional<bool> typing_detection;
244 rtc::Optional<bool> aecm_generate_comfort_noise; 249 rtc::Optional<bool> aecm_generate_comfort_noise;
245 rtc::Optional<int> adjust_agc_delta; 250 rtc::Optional<int> adjust_agc_delta;
246 rtc::Optional<bool> experimental_agc; 251 rtc::Optional<bool> experimental_agc;
247 rtc::Optional<bool> extended_filter_aec; 252 rtc::Optional<bool> extended_filter_aec;
248 rtc::Optional<bool> delay_agnostic_aec; 253 rtc::Optional<bool> delay_agnostic_aec;
249 rtc::Optional<bool> experimental_ns; 254 rtc::Optional<bool> experimental_ns;
250 rtc::Optional<bool> intelligibility_enhancer; 255 rtc::Optional<bool> intelligibility_enhancer;
256 rtc::Optional<bool> level_control;
251 // Note that tx_agc_* only applies to non-experimental AGC. 257 // Note that tx_agc_* only applies to non-experimental AGC.
252 rtc::Optional<uint16_t> tx_agc_target_dbov; 258 rtc::Optional<uint16_t> tx_agc_target_dbov;
253 rtc::Optional<uint16_t> tx_agc_digital_compression_gain; 259 rtc::Optional<uint16_t> tx_agc_digital_compression_gain;
254 rtc::Optional<bool> tx_agc_limiter; 260 rtc::Optional<bool> tx_agc_limiter;
255 rtc::Optional<uint32_t> recording_sample_rate; 261 rtc::Optional<uint32_t> recording_sample_rate;
256 rtc::Optional<uint32_t> playout_sample_rate; 262 rtc::Optional<uint32_t> playout_sample_rate;
257 // Enable combined audio+bandwidth BWE. 263 // Enable combined audio+bandwidth BWE.
258 // TODO(pthatcher): This flag is set from the 264 // TODO(pthatcher): This flag is set from the
259 // "googCombinedAudioVideoBwe", but not used anywhere. So delete it, 265 // "googCombinedAudioVideoBwe", but not used anywhere. So delete it,
260 // and check if any other AudioOptions members are unused. 266 // and check if any other AudioOptions members are unused.
(...skipping 863 matching lines...) Expand 10 before | Expand all | Expand 10 after
1124 // Signal when the media channel is ready to send the stream. Arguments are: 1130 // Signal when the media channel is ready to send the stream. Arguments are:
1125 // writable(bool) 1131 // writable(bool)
1126 sigslot::signal1<bool> SignalReadyToSend; 1132 sigslot::signal1<bool> SignalReadyToSend;
1127 // Signal for notifying that the remote side has closed the DataChannel. 1133 // Signal for notifying that the remote side has closed the DataChannel.
1128 sigslot::signal1<uint32_t> SignalStreamClosedRemotely; 1134 sigslot::signal1<uint32_t> SignalStreamClosedRemotely;
1129 }; 1135 };
1130 1136
1131 } // namespace cricket 1137 } // namespace cricket
1132 1138
1133 #endif // WEBRTC_MEDIA_BASE_MEDIACHANNEL_H_ 1139 #endif // WEBRTC_MEDIA_BASE_MEDIACHANNEL_H_
OLDNEW
« no previous file with comments | « webrtc/api/mediaconstraintsinterface.cc ('k') | webrtc/media/engine/webrtcvoiceengine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698