Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: webrtc/api/localaudiosource.cc

Issue 2095563002: Adding activation logic of the new APM level control functionality using MediaConstraints (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@ALC_RC2_CL
Patch Set: Changed logging behavior according to reviewer comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 options->delay_agnostic_aec}, 42 options->delay_agnostic_aec},
43 {MediaConstraintsInterface::kAutoGainControl, options->auto_gain_control}, 43 {MediaConstraintsInterface::kAutoGainControl, options->auto_gain_control},
44 {MediaConstraintsInterface::kExperimentalAutoGainControl, 44 {MediaConstraintsInterface::kExperimentalAutoGainControl,
45 options->experimental_agc}, 45 options->experimental_agc},
46 {MediaConstraintsInterface::kNoiseSuppression, 46 {MediaConstraintsInterface::kNoiseSuppression,
47 options->noise_suppression}, 47 options->noise_suppression},
48 {MediaConstraintsInterface::kExperimentalNoiseSuppression, 48 {MediaConstraintsInterface::kExperimentalNoiseSuppression,
49 options->experimental_ns}, 49 options->experimental_ns},
50 {MediaConstraintsInterface::kIntelligibilityEnhancer, 50 {MediaConstraintsInterface::kIntelligibilityEnhancer,
51 options->intelligibility_enhancer}, 51 options->intelligibility_enhancer},
52 {MediaConstraintsInterface::kLevelControl, options->level_control},
52 {MediaConstraintsInterface::kHighpassFilter, options->highpass_filter}, 53 {MediaConstraintsInterface::kHighpassFilter, options->highpass_filter},
53 {MediaConstraintsInterface::kTypingNoiseDetection, 54 {MediaConstraintsInterface::kTypingNoiseDetection,
54 options->typing_detection}, 55 options->typing_detection},
55 {MediaConstraintsInterface::kAudioMirroring, options->stereo_swapping} 56 {MediaConstraintsInterface::kAudioMirroring, options->stereo_swapping}};
hlundin-webrtc 2016/06/27 11:44:27 I presume clang-format gave you this, but in this
peah-webrtc 2016/06/27 23:00:05 Yes, that was clang-format, and I definitely agree
56 };
57 57
58 for (const auto& constraint : constraints) { 58 for (const auto& constraint : constraints) {
59 bool value = false; 59 bool value = false;
60 if (!rtc::FromString(constraint.value, &value)) 60 if (!rtc::FromString(constraint.value, &value))
61 continue; 61 continue;
62 62
63 for (auto& entry : key_to_value) { 63 for (auto& entry : key_to_value) {
64 if (constraint.key.compare(entry.name) == 0) 64 if (constraint.key.compare(entry.name) == 0)
65 entry.value = rtc::Optional<bool>(value); 65 entry.value = rtc::Optional<bool>(value);
66 } 66 }
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 void LocalAudioSource::Initialize( 105 void LocalAudioSource::Initialize(
106 const PeerConnectionFactoryInterface::Options& options, 106 const PeerConnectionFactoryInterface::Options& options,
107 const cricket::AudioOptions* audio_options) { 107 const cricket::AudioOptions* audio_options) {
108 if (!audio_options) 108 if (!audio_options)
109 return; 109 return;
110 110
111 options_ = *audio_options; 111 options_ = *audio_options;
112 } 112 }
113 113
114 } // namespace webrtc 114 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/mediaconstraintsinterface.h » ('j') | webrtc/media/engine/webrtcvoiceengine.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698