Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2094863003: Reland of "Revert of Update the BWE when the network route changes. (Closed)

Created:
4 years, 6 months ago by honghaiz3
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, zhuangzesen_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of "Revert of Update the BWE when the network route changes. (patchset #5 id:180001 of https://… (patchset #1 id:1 of https://codereview.webrtc.org/2098703004/ ) Reason for revert: It turns out this revert was not necessary because the connection-state mapping for turn-turn connections was not done in connection. Original issue's description: > Revert of Revert "Revert of Update the BWE when the network route changes. (patchset #5 id:180001 of https://… (patchset #5 id:120001 of https://codereview.webrtc.org/2041593002/ ) > > Reason for revert: > ReadyToSendMedia did not consider the new presumed_writable state. > > Original issue's description: > > Revert "Revert of Update the BWE when the network route changes. (patchset #5 id:180001 of https://codereview.webrtc.org/2000063003/ )" > > > > This reverts commit 72d41aa6da94dacb8a8464d1abd4ca7d1afffc65. > > > > New change made: > > Do not reset the BWE when the new network route is not ready to send media. > > > > BUG= > > R=pthatcher@webrtc.org, stefan@webrtc.org > > TBR=pthatcher@webrtc.org,stefan@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/059e1834197df9ed8b8b232cc90b19927941119e Cr-Commit-Position: refs/heads/master@{#13282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -19 lines) Patch
M webrtc/base/networkroute.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/call/call.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/bitrate_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/mock/mock_bitrate_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 3 chunks +39 lines, -12 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/p2p/base/candidatepairinterface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/p2p/base/port.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/p2p/base/port.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/channel.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/pc/channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
honghaiz3
Created Reland of "Revert of Update the BWE when the network route changes. (patchset #5 ...
4 years, 6 months ago (2016-06-24 17:50:46 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14447) linux_gn_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 6 months ago (2016-06-24 17:59:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2094863003/1
4 years, 6 months ago (2016-06-24 18:03:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 18:03:59 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 18:04:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/059e1834197df9ed8b8b232cc90b19927941119e
Cr-Commit-Position: refs/heads/master@{#13282}

Powered by Google App Engine
This is Rietveld 408576698