Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2092633002: Revert of Move FilePlayer and FileRecorder to Voice Engine (Closed)

Created:
4 years, 6 months ago by kwiberg-webrtc
Modified:
4 years, 6 months ago
Reviewers:
the sun, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove0
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Move FilePlayer and FileRecorder to Voice Engine (patchset #5 id:80001 of https://codereview.chromium.org/2037623002/ ) Reason for revert: voice_engine_unittests: FilePlayerTest.PlayWavPcm16File and FilePlayerTest.PlayWavPcmuFile fail on 32-bit android (android_rel and android-dbg try bots, Android32 Tests (L Nexus5) and Android32 Tests (L Nexus7.2) build bots). Not sure why this would happen, since I just moved the test without modifying it. Some test filtering that no longer manages to disable them? Anyway, reverting until I know how to fix. This was actually caught by the try bots, but I missed it because I was manually ignoring them because of an error with the bots. :-( Original issue's description: > Move FilePlayer and FileRecorder to Voice Engine > > Because Voice Engine was the only user. > > R=perkj@webrtc.org, solenberg@webrtc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/65874b163ee5d6eb460c53590702ed98ca399605 TBR=perkj@webrtc.org,solenberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/e7edea97592733649ac067355da122b047b128cd Cr-Commit-Position: refs/heads/master@{#13267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1291 lines, -1297 lines) Patch
M webrtc/modules/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/utility/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
A webrtc/modules/utility/include/file_player.h View 1 chunk +86 lines, -0 lines 0 comments Download
A webrtc/modules/utility/include/file_recorder.h View 1 chunk +64 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/coder.h View 1 chunk +68 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/coder.cc View 1 chunk +116 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/file_player_impl.h View 1 chunk +78 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/file_player_impl.cc View 1 chunk +402 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/file_player_unittests.cc View 1 chunk +116 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/file_recorder_impl.h View 1 chunk +79 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/file_recorder_impl.cc View 1 chunk +259 lines, -0 lines 0 comments Download
M webrtc/modules/utility/utility.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/voice_engine/coder.h View 1 chunk +0 lines, -68 lines 0 comments Download
D webrtc/voice_engine/coder.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D webrtc/voice_engine/file_player.h View 1 chunk +0 lines, -87 lines 0 comments Download
D webrtc/voice_engine/file_player_impl.h View 1 chunk +0 lines, -79 lines 0 comments Download
D webrtc/voice_engine/file_player_impl.cc View 1 chunk +0 lines, -403 lines 0 comments Download
D webrtc/voice_engine/file_player_unittests.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D webrtc/voice_engine/file_recorder.h View 1 chunk +0 lines, -65 lines 0 comments Download
D webrtc/voice_engine/file_recorder_impl.h View 1 chunk +0 lines, -80 lines 0 comments Download
D webrtc/voice_engine/file_recorder_impl.cc View 1 chunk +0 lines, -260 lines 0 comments Download
M webrtc/voice_engine/output_mixer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/transmit_mixer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
Created Revert of Move FilePlayer and FileRecorder to Voice Engine
4 years, 6 months ago (2016-06-22 23:29:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092633002/1
4 years, 6 months ago (2016-06-22 23:29:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 23:29:58 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e7edea97592733649ac067355da122b047b128cd Cr-Commit-Position: refs/heads/master@{#13267}
4 years, 6 months ago (2016-06-22 23:30:05 UTC) #7
kwiberg-webrtc
4 years, 6 months ago (2016-06-22 23:36:05 UTC) #8
Message was sent while issue was closed.
The tests moved from modules_unittests to voice_engine_unittests. Would that
make a difference?

Powered by Google App Engine
This is Rietveld 408576698