Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2092273003: Revert of Use VoiceChannel/VideoChannel directly from RtpSender/RtpReceiver. (Closed)

Created:
4 years, 6 months ago by tkchin_webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Use VoiceChannel/VideoChannel directly from RtpSender/RtpReceiver. (patchset #3 id:40001 of https://codereview.webrtc.org/2046173002/ ) Reason for revert: Broke video sending for iOS AppRTCDemo. To repro, run iOS AppRTCDemo in Release in loopback mode. The revision prior to this change worked. Original issue's description: > Reland of: Use VoiceChannel/VideoChannel directly from RtpSender/RtpReceiver. > > This eliminates the need for the extra layer of indirection provided by > mediastreamprovider.h. It will thus make it easier to implement new > functionality in RtpSender/RtpReceiver. > > It also brings us one step closer to the end goal of combining "senders" > and "send streams". Currently the sender still needs to go through the > BaseChannel and MediaChannel, using an SSRC as a key. > > R=pthatcher@webrtc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/2d5491783a264c6e57614f87f1a69dc61bf44609 TBR=pthatcher@webrtc.org,deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3784b4a697d4ca5efb598e8427adbe22752a6f3f Cr-Commit-Position: refs/heads/master@{#13289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+984 lines, -733 lines) Patch
M webrtc/api/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/api.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/datachannel.cc View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/api/mediastreamprovider.h View 1 chunk +120 lines, -0 lines 0 comments Download
M webrtc/api/peerconnection.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/api/peerconnection.cc View 11 chunks +26 lines, -63 lines 0 comments Download
M webrtc/api/remoteaudiosource.h View 4 chunks +6 lines, -4 lines 0 comments Download
M webrtc/api/remoteaudiosource.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M webrtc/api/rtpreceiver.h View 5 chunks +49 lines, -65 lines 0 comments Download
M webrtc/api/rtpreceiver.cc View 4 chunks +31 lines, -92 lines 0 comments Download
M webrtc/api/rtpreceiverinterface.h View 5 chunks +3 lines, -13 lines 0 comments Download
M webrtc/api/rtpsender.h View 7 chunks +9 lines, -26 lines 0 comments Download
M webrtc/api/rtpsender.cc View 9 chunks +33 lines, -69 lines 0 comments Download
M webrtc/api/rtpsenderreceiver_unittest.cc View 9 chunks +312 lines, -372 lines 0 comments Download
M webrtc/api/webrtcsession.h View 4 chunks +43 lines, -5 lines 0 comments Download
M webrtc/api/webrtcsession.cc View 4 chunks +174 lines, -0 lines 0 comments Download
M webrtc/api/webrtcsession_unittest.cc View 2 chunks +162 lines, -0 lines 0 comments Download
M webrtc/media/base/fakemediaengine.h View 3 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkchin_webrtc
Created Revert of Use VoiceChannel/VideoChannel directly from RtpSender/RtpReceiver.
4 years, 6 months ago (2016-06-25 02:31:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2092273003/1
4 years, 6 months ago (2016-06-25 02:31:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-25 02:31:52 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-25 02:32:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3784b4a697d4ca5efb598e8427adbe22752a6f3f
Cr-Commit-Position: refs/heads/master@{#13289}

Powered by Google App Engine
This is Rietveld 408576698