Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2092023004: Revert of Add virtual Initialize methods to PortAllocator and NetworkManager. (Closed)

Created:
4 years, 6 months ago by Taylor Brandstetter
Modified:
4 years, 6 months ago
Reviewers:
pthatcher1, skvlad
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add virtual Initialize methods to PortAllocator and NetworkManager. (patchset #4 id:60001 of https://codereview.webrtc.org/2097653002/ ) Reason for revert: Didn't intend to land yet. Chromium CL still needed. Original issue's description: > Add virtual Initialize methods to PortAllocator and NetworkManager. > > This will allow PeerConnection to handle hopping to the right thread > and doing thread-specific initialization for the PortAllocator. > This eliminates a required thread-hop for whatever is passing the > PortAllocator into CreatePeerConnection. > > BUG=617648 > R=pthatcher@webrtc.org, skvlad@webrtc.org > > Committed: https://crrev.com/a6bdb0990a659ff9e7c4374f5033a6bcc4fbfb21 > Cr-Commit-Position: refs/heads/master@{#13283} TBR=pthatcher@webrtc.org,skvlad@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617648 Committed: https://crrev.com/ba8d4337b7751e57161c8b0dfa77d3e4faeb953b Cr-Commit-Position: refs/heads/master@{#13284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -63 lines) Patch
M webrtc/api/peerconnection.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M webrtc/base/network.h View 2 chunks +0 lines, -11 lines 0 comments Download
M webrtc/p2p/base/fakeportallocator.h View 6 chunks +9 lines, -18 lines 0 comments Download
M webrtc/p2p/base/portallocator.h View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Taylor Brandstetter
Created Revert of Add virtual Initialize methods to PortAllocator and NetworkManager.
4 years, 6 months ago (2016-06-24 21:04:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2092023004/1
4 years, 6 months ago (2016-06-24 21:04:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 21:05:15 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 21:05:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba8d4337b7751e57161c8b0dfa77d3e4faeb953b
Cr-Commit-Position: refs/heads/master@{#13284}

Powered by Google App Engine
This is Rietveld 408576698