Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2091983002: Revert of Cleanups in cricket::VideoFrame and cricket::WebRtcVideoFrame. (Closed)

Created:
4 years, 6 months ago by honghaiz3
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, nisse-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Cleanups in cricket::VideoFrame and cricket::WebRtcVideoFrame. (patchset #5 id:110001 of https://codereview.webrtc.org/2075983003/ ) Reason for revert: Breaking Chrome FYI bots. Original issue's description: > Cleanups in cricket::VideoFrame and cricket::WebRtcVideoFrame. > > Removed some protected virtual methods from VideoFrame that no longer > need to exist. Some minor cleanups in the tests. > > BUG=webrtc:5682 > > Committed: https://crrev.com/742d7b10b9720ec43de26e0faef52e5cb9c0daa8 > Cr-Commit-Position: refs/heads/master@{#13275} TBR=pbos@webrtc.org,nisse@webrtc.org,deadbeef@webrtc.org,sergeyu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Committed: https://crrev.com/7cf740323033b50845eed0ffe1e9802ae327cd8b Cr-Commit-Position: refs/heads/master@{#13277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -51 lines) Patch
M webrtc/media/base/videoframe.h View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 5 chunks +7 lines, -7 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 4 chunks +6 lines, -3 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 3 chunks +36 lines, -19 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 8 chunks +48 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
honghaiz3
Created Revert of Cleanups in cricket::VideoFrame and cricket::WebRtcVideoFrame.
4 years, 6 months ago (2016-06-23 23:43:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091983002/1
4 years, 6 months ago (2016-06-23 23:43:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 23:43:53 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 23:44:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cf740323033b50845eed0ffe1e9802ae327cd8b
Cr-Commit-Position: refs/heads/master@{#13277}

Powered by Google App Engine
This is Rietveld 408576698