Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2091433002:
[MIPS] Fix build issue for mips64el (Closed)
|
Created:
4 years, 6 months ago by lmilko Modified:
4 years, 6 months ago CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, petar.jovanovic, gordana.cmiljanovic_imgtec.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
Description[MIPS] Fix build issue for mips64el
Fixing build issue for mips64el by removing
WEBRTC_ARCH_MIPS64_FAMILY, and using WEBRTC_ARCH_MIPS_FAMILY
for both mipsel and mips64el.
BUG=undefined reference to webrtc::BlockDifference_SSE2_W32()
TEST=GYP_DEFINES="target_arch=mips64el mips_arch_variant=r2
sysroot=<PATH_TO_SYSROOT>" webrtc/build/gyp_webrtc.py
ninja -C out/Release
NOTRY=True
Committed: https://crrev.com/1fdcc28b25a257d460582e25956b43ef17ce03bd
Cr-Commit-Position: refs/heads/master@{#13272}
Patch Set 1 #
Messages
Total messages: 23 (10 generated)
milko.leporis@imgtec.com changed reviewers: + kjellander@webrtc.org, ljubomir.papuga@imgtec.com
Similar change was done already in chromium, as part of change https://codereview.chromium.org/1892823002/ Please take a look.
lgtm
lgtm
The CQ bit was checked by milko.leporis@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091433002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6477)
milko.leporis@imgtec.com changed reviewers: + tina.legrand@webrtc.org, tommi@webrtc.org
Needs approval from owners. PTAL
lgtm
The CQ bit was checked by milko.leporis@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091433002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14409)
On 2016/06/23 08:52:27, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_dbg on tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14409) bots should be fixed with https://codereview.chromium.org/2086333004/ but since this hardly affects Android tests, I'll put NOTRY=True in and CQ it.
Description was changed from
==========
[MIPS] Fix build issue for mips64el
Fixing build issue for mips64el by removing
WEBRTC_ARCH_MIPS64_FAMILY, and using WEBRTC_ARCH_MIPS_FAMILY
for both mipsel and mips64el.
BUG=undefined reference to webrtc::BlockDifference_SSE2_W32()
TEST=GYP_DEFINES="target_arch=mips64el mips_arch_variant=r2
sysroot=<PATH_TO_SYSROOT>" webrtc/build/gyp_webrtc.py
ninja -C out/Release
==========
to
==========
[MIPS] Fix build issue for mips64el
Fixing build issue for mips64el by removing
WEBRTC_ARCH_MIPS64_FAMILY, and using WEBRTC_ARCH_MIPS_FAMILY
for both mipsel and mips64el.
BUG=undefined reference to webrtc::BlockDifference_SSE2_W32()
TEST=GYP_DEFINES="target_arch=mips64el mips_arch_variant=r2
sysroot=<PATH_TO_SYSROOT>" webrtc/build/gyp_webrtc.py
ninja -C out/Release
NOTRY=True
==========
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091433002/1
Message was sent while issue was closed.
Description was changed from
==========
[MIPS] Fix build issue for mips64el
Fixing build issue for mips64el by removing
WEBRTC_ARCH_MIPS64_FAMILY, and using WEBRTC_ARCH_MIPS_FAMILY
for both mipsel and mips64el.
BUG=undefined reference to webrtc::BlockDifference_SSE2_W32()
TEST=GYP_DEFINES="target_arch=mips64el mips_arch_variant=r2
sysroot=<PATH_TO_SYSROOT>" webrtc/build/gyp_webrtc.py
ninja -C out/Release
NOTRY=True
==========
to
==========
[MIPS] Fix build issue for mips64el
Fixing build issue for mips64el by removing
WEBRTC_ARCH_MIPS64_FAMILY, and using WEBRTC_ARCH_MIPS_FAMILY
for both mipsel and mips64el.
BUG=undefined reference to webrtc::BlockDifference_SSE2_W32()
TEST=GYP_DEFINES="target_arch=mips64el mips_arch_variant=r2
sysroot=<PATH_TO_SYSROOT>" webrtc/build/gyp_webrtc.py
ninja -C out/Release
NOTRY=True
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
[MIPS] Fix build issue for mips64el
Fixing build issue for mips64el by removing
WEBRTC_ARCH_MIPS64_FAMILY, and using WEBRTC_ARCH_MIPS_FAMILY
for both mipsel and mips64el.
BUG=undefined reference to webrtc::BlockDifference_SSE2_W32()
TEST=GYP_DEFINES="target_arch=mips64el mips_arch_variant=r2
sysroot=<PATH_TO_SYSROOT>" webrtc/build/gyp_webrtc.py
ninja -C out/Release
NOTRY=True
==========
to
==========
[MIPS] Fix build issue for mips64el
Fixing build issue for mips64el by removing
WEBRTC_ARCH_MIPS64_FAMILY, and using WEBRTC_ARCH_MIPS_FAMILY
for both mipsel and mips64el.
BUG=undefined reference to webrtc::BlockDifference_SSE2_W32()
TEST=GYP_DEFINES="target_arch=mips64el mips_arch_variant=r2
sysroot=<PATH_TO_SYSROOT>" webrtc/build/gyp_webrtc.py
ninja -C out/Release
NOTRY=True
Committed: https://crrev.com/1fdcc28b25a257d460582e25956b43ef17ce03bd
Cr-Commit-Position: refs/heads/master@{#13272}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1fdcc28b25a257d460582e25956b43ef17ce03bd Cr-Commit-Position: refs/heads/master@{#13272} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
