Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2090833002: Revert of Do not delete a connection in the turn port with permission error or refresh error. (Closed)

Created:
4 years, 6 months ago by honghaiz3
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Do not delete a connection in the turn port with permission error or refresh error. (patchset #6 id:260001 of https://codereview.webrtc.org/2068263003/ ) Reason for revert: It broke webrtc builds. Original issue's description: > Do not delete a connection in the turn port with permission error, refresh error, or binding error. > > Even if those error happened, the connection may still be able to receive packets for a while. > If we delete the connections, all packets arriving will be dropped. > > BUG=webrtc:6007 > R=deadbeef@webrtc.org, pthatcher@webrtc.org > > Committed: https://crrev.com/3d77deb29c15bfb8f794ef3413837a0ec0f0c131 > Cr-Commit-Position: refs/heads/master@{#13262} NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=pthatcher@webrtc.org,deadbeef@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6007 Committed: https://crrev.com/3159ffae6b1d5cba2ad972bd3d8074ac85f2c7f9 Cr-Commit-Position: refs/heads/master@{#13265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -142 lines) Patch
M webrtc/base/virtualsocketserver.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M webrtc/p2p/base/port.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/p2p/base/port.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/p2p/base/turnport.h View 3 chunks +5 lines, -8 lines 0 comments Download
M webrtc/p2p/base/turnport.cc View 9 chunks +22 lines, -29 lines 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 11 chunks +35 lines, -72 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
honghaiz3
Created Revert of Do not delete a connection in the turn port with permission error ...
4 years, 6 months ago (2016-06-22 23:17:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090833002/1
4 years, 6 months ago (2016-06-22 23:17:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090833002/1
4 years, 6 months ago (2016-06-22 23:18:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 23:18:32 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3159ffae6b1d5cba2ad972bd3d8074ac85f2c7f9 Cr-Commit-Position: refs/heads/master@{#13265}
4 years, 6 months ago (2016-06-22 23:18:56 UTC) #11
honghaiz3
4 years, 6 months ago (2016-06-22 23:26:15 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2090073003/ by honghaiz@webrtc.org.

The reason for reverting is: The Webrtc waterfall indicates that this revert is
not necessary. .

Powered by Google App Engine
This is Rietveld 408576698