Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2090823002: Revert of Adding IceConfig option to assume TURN/TURN candidate pairs will work. (Closed)

Created:
4 years, 6 months ago by honghaiz3
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding IceConfig option to assume TURN/TURN candidate pairs will work. (patchset #9 id:160001 of https://codereview.webrtc.org/2063823008/ ) Reason for revert: Breaking webrtc builder. Original issue's description: > Adding IceConfig option to assume TURN/TURN candidate pairs will work. > > This will allow media to be sent on these pairs before a binding > response is received, shortening call setup time. However, this is only > possible if the TURN servers don't require CreatePermission when > communicating with each other. > > R=honghaiz@webrtc.org, pthatcher@webrtc.org > > Committed: https://crrev.com/8e6134eae4117a239de67c9a9dae8f5e3235d803 > Cr-Commit-Position: refs/heads/master@{#13263} NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=pthatcher@webrtc.org,deadbeef@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/13d5db38575fb19c1ddf69b4da379cd4a3aa3ac6 Cr-Commit-Position: refs/heads/master@{#13264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+682 lines, -795 lines) Patch
M webrtc/api/webrtcsession_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 2 chunks +0 lines, -15 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 9 chunks +157 lines, -197 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 89 chunks +521 lines, -570 lines 0 comments Download
M webrtc/p2p/base/port.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transport.h View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
honghaiz3
Created Revert of Adding IceConfig option to assume TURN/TURN candidate pairs will work.
4 years, 6 months ago (2016-06-22 23:08:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090823002/1
4 years, 6 months ago (2016-06-22 23:08:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090823002/1
4 years, 6 months ago (2016-06-22 23:15:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090823002/1
4 years, 6 months ago (2016-06-22 23:15:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 23:15:14 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 23:15:22 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13d5db38575fb19c1ddf69b4da379cd4a3aa3ac6
Cr-Commit-Position: refs/heads/master@{#13264}

Powered by Google App Engine
This is Rietveld 408576698