Refactoring on QUIC

webrtc/p2p/quic/reliablequicstream_unittest.cc

Index: webrtc/p2p/quic/reliablequicstream_unittest.cc
diff --git a/webrtc/p2p/quic/reliablequicstream_unittest.cc b/webrtc/p2p/quic/reliablequicstream_unittest.cc
index cf9f5e92ddfb06507e242706700d6fbf91d109f8..55095cc4d294db4d98e31d718b915cf96adf7458 100644
--- a/webrtc/p2p/quic/reliablequicstream_unittest.cc
+++ b/webrtc/p2p/quic/reliablequicstream_unittest.cc
@@ -49,6 +49,7 @@ using rtc::SR_BLOCK;
 
 // Arbitrary number for a stream's write blocked priority.
 static const SpdyPriority kDefaultPriority = 3;
+static const net::QuicStreamId kStreamId = 5;
 
 // QuicSession that does not create streams and writes data from
 // ReliableQuicStream to a string.
@@ -78,7 +79,7 @@ class MockQuicSession : public QuicSession {
 
   net::ReliableQuicStream* CreateIncomingDynamicStream(
       QuicStreamId id) override {
-    return nullptr;
+    return new ReliableQuicStream(kStreamId, this);
   }
 
   net::ReliableQuicStream* CreateOutgoingDynamicStream(
@@ -139,10 +140,10 @@ class DummyPacketWriter : public QuicPacketWriter {
 class ReliableQuicStreamTest : public ::testing::Test,
                                public sigslot::has_slots<> {
  public:
+
   ReliableQuicStreamTest() {}
 
   void CreateReliableQuicStream() {
-    const net::QuicStreamId kStreamId = 5;
 
     // Arbitrary values for QuicConnection.
     QuicConnectionHelper* quic_helper =
@@ -232,7 +233,7 @@ TEST_F(ReliableQuicStreamTest, BufferData) {
 // Read an entire string.
 TEST_F(ReliableQuicStreamTest, ReadDataWhole) {
   CreateReliableQuicStream();
-  net::QuicStreamFrame frame(-1, false, 0, "Hello, World!");
+  net::QuicStreamFrame frame(kStreamId, false, 0, "Hello, World!");
   stream_->OnStreamFrame(frame);
 
   EXPECT_EQ("Hello, World!", read_buffer_);
@@ -241,7 +242,7 @@ TEST_F(ReliableQuicStreamTest, ReadDataWhole) {
 // Read part of a string.
 TEST_F(ReliableQuicStreamTest, ReadDataPartial) {
   CreateReliableQuicStream();
-  net::QuicStreamFrame frame(-1, false, 0, "Hello, World!");
+  net::QuicStreamFrame frame(kStreamId, false, 0, "Hello, World!");
   frame.frame_length = 5;
   stream_->OnStreamFrame(frame);