webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc - Issue 2089183002: Don't recreate the speech encoder if we don't have to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc

Issue 2089183002: Don't recreate the speech encoder if we don't have to (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/codecs/audio_encoder.h ('K') | « webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h ('k') | webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc

diff --git a/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc b/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc

index 09c25d9616c4d5fa805f184ff973a842f2c824d2..d2edcb5c26557baa12832264152b56f5cb4e6547 100644

--- a/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc

+++ b/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc

@@ -187,6 +187,11 @@ void AudioEncoderCng::SetTargetBitrate(int bits_per_second) {

speech_encoder_->SetTargetBitrate(bits_per_second);

}

+rtc::ArrayView<std::unique_ptr<AudioEncoder>>

+AudioEncoderCng::ReclaimContainedEncoders() {

+ return rtc::ArrayView<std::unique_ptr<AudioEncoder>>(&speech_encoder_, 1);

AudioEncoder::EncodedInfo AudioEncoderCng::EncodePassive(

size_t frames_to_encode,

rtc::Buffer* encoded) {