Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2088513004: Add encoder/decoder names to software H264. (Closed)

Created:
4 years, 6 months ago by pbos-webrtc
Modified:
4 years, 6 months ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add encoder/decoder names to software H264. BUG= R=hbos@webrtc.org Committed: https://crrev.com/329c9407e02cf7e4e04378325ac478efae2b757b Cr-Commit-Position: refs/heads/master@{#13258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL
4 years, 6 months ago (2016-06-22 16:24:30 UTC) #1
hbos
lgtm! Fantastic, this will help with debugging.
4 years, 6 months ago (2016-06-22 16:26:40 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/329c9407e02cf7e4e04378325ac478efae2b757b Cr-Commit-Position: refs/heads/master@{#13258}
4 years, 6 months ago (2016-06-22 16:27:15 UTC) #5
pbos-webrtc
4 years, 6 months ago (2016-06-22 16:27:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
329c9407e02cf7e4e04378325ac478efae2b757b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698