webrtc/api/java/jni/peerconnection_jni.cc - Issue 2087923004: Revert of Delete method cricket::VideoFrame::Copy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/java/jni/peerconnection_jni.cc

Issue 2087923004: Revert of Delete method cricket::VideoFrame::Copy. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/api/java/jni/peerconnection_jni.cc

diff --git a/webrtc/api/java/jni/peerconnection_jni.cc b/webrtc/api/java/jni/peerconnection_jni.cc

index 2b08f751c739bc7d3992dd39ab9974d15cb5f53b..a5ba254c32461222cd9d5e35508943c16dbee40d 100644

--- a/webrtc/api/java/jni/peerconnection_jni.cc

+++ b/webrtc/api/java/jni/peerconnection_jni.cc

@@ -768,8 +768,7 @@

// ownership of the frame, and the frame should be released with

// VideoRenderer.releaseNativeFrame().

static jlong javaShallowCopy(const cricket::VideoFrame* frame) {

- return jlongFromPointer(new cricket::WebRtcVideoFrame(

- frame->video_frame_buffer(), frame->rotation(), frame->timestamp_us()));

+ return jlongFromPointer(frame->Copy());

}

// Return a VideoRenderer.I420Frame referring to the data in |frame|.

« no previous file with comments | « talk/app/webrtc/objc/RTCI420Frame.mm ('k') | webrtc/media/base/videoframe.h » ('j') | no next file with comments »