Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: webrtc/media/base/videoframe_unittest.h

Issue 2087923004: Revert of Delete method cricket::VideoFrame::Copy. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/base/videoframe.h ('k') | webrtc/media/engine/webrtcvideoframe.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/videoframe_unittest.h
diff --git a/webrtc/media/base/videoframe_unittest.h b/webrtc/media/base/videoframe_unittest.h
index 38c3f85a71f80523ed003b59480e5f8fc0180b61..39985617c5ae6fcf209e746d3464e241ca9962b3 100644
--- a/webrtc/media/base/videoframe_unittest.h
+++ b/webrtc/media/base/videoframe_unittest.h
@@ -1808,6 +1808,31 @@
EXPECT_TRUE(IsEqual(frame1, frame2, 1));
}
+ ///////////////////
+ // General tests //
+ ///////////////////
+
+ void Copy() {
+ std::unique_ptr<T> source(new T);
+ std::unique_ptr<cricket::VideoFrame> target;
+ ASSERT_TRUE(LoadFrameNoRepeat(source.get()));
+ target.reset(source->Copy());
+ EXPECT_TRUE(IsEqual(*source, *target, 0));
+ source.reset();
+ ASSERT_TRUE(target->video_frame_buffer() != NULL);
+ EXPECT_TRUE(target->video_frame_buffer()->DataY() != NULL);
+ }
+
+ void CopyIsRef() {
+ std::unique_ptr<T> source(new T);
+ std::unique_ptr<const cricket::VideoFrame> target;
+ ASSERT_TRUE(LoadFrameNoRepeat(source.get()));
+ target.reset(source->Copy());
+ EXPECT_TRUE(IsEqual(*source, *target, 0));
+ const T* const_source = source.get();
+ EXPECT_EQ(const_source->video_frame_buffer(), target->video_frame_buffer());
+ }
+
int repeat_;
};
« no previous file with comments | « webrtc/media/base/videoframe.h ('k') | webrtc/media/engine/webrtcvideoframe.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698