Set the generation on peer reflexive candidates when created.

Set the generation on peer reflexive candidates when created.

If an actual peer reflexive candidate was created (and not one that
would just be replaced by a different candidate later), we weren't
setting the generation value. This means that new-generation prflx
candidate pairs weren't being prioritized above the cross-generation
pairs, or above relay<->relay pairs.

R=honghaiz@webrtc.org, pthatcher@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/f7c15a915924d5a2c2afb7eeaed828728da1f9ec

[Taylor Brandstetter, 2016-06-21 01:53:09]

deadbeef@webrtc.org changed reviewers:
+ honghaiz@webrtc.org, pthatcher@webrtc.org

[Taylor Brandstetter, 2016-06-21 01:53:10]

https://codereview.webrtc.org/2086793002/diff/1/webrtc/p2p/base/p2ptransportc...
File webrtc/p2p/base/p2ptransportchannel.cc (left):

https://codereview.webrtc.org/2086793002/diff/1/webrtc/p2p/base/p2ptransportc...
webrtc/p2p/base/p2ptransportchannel.cc:577: // Determine if the remote
candidates use shared ufrag.
This is code to handle the "disable shared ufrag" option, which has been out of
our code base for a long time, and isn't even really handled in the rest of this
class. So it seems sensible to delete it.

https://codereview.webrtc.org/2086793002/diff/1/webrtc/p2p/base/p2ptransportc...
File webrtc/p2p/base/p2ptransportchannel_unittest.cc (right):

https://codereview.webrtc.org/2086793002/diff/1/webrtc/p2p/base/p2ptransportc...
webrtc/p2p/base/p2ptransportchannel_unittest.cc:1287:
set_clear_remote_candidates_ufrag_pwd(true);
A couple tests needed to be updated because they were NOT calling
SetIceCredentials, and instead relying on the code for non-shared ufrag I
deleted. But in the real world everyone will call SetIceCredentials.

[Taylor Brandstetter, 2016-06-21 01:53:21]

Description was changed from

==========
Set the generation on peer reflexive candidates.

If an actual peer reflexive candidate was created (and not one that
would just be replaced by a different candidate later), we weren't
setting the generation value. This means that new-generation prflx
candidate pairs weren't being prioritized above the cross-generation
pairs, or above relay<->relay pairs.
==========

to

==========
Set the generation on peer reflexive candidates when created.

If an actual peer reflexive candidate was created (and not one that
would just be replaced by a different candidate later), we weren't
setting the generation value. This means that new-generation prflx
candidate pairs weren't being prioritized above the cross-generation
pairs, or above relay<->relay pairs.
==========

[pthatcher1, 2016-06-21 05:15:41]

lgtm

[pthatcher1, 2016-06-21 05:15:52]

Nice find and fix.

[honghaiz3, 2016-06-22 17:40:09]

lgtm

[Taylor Brandstetter, 2016-06-22 18:07:38]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-06-22 18:07:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086793002/1

[commit-bot: I haz the power, 2016-06-22 18:11:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 18:11:37]

Try jobs failed on following builders:
  android_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/14346)
  linux_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...)

[Taylor Brandstetter, 2016-06-22 18:31:08]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2016-06-22 18:31:09]

The patchset sent to the CQ was uploaded after l-g-t-m from honghaiz@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2086793002/#ps20001 (title:
"Updating unit test.")

[commit-bot: I haz the power, 2016-06-22 18:31:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086793002/20001

[commit-bot: I haz the power, 2016-06-22 19:28:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 19:28:51]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14380)

[Taylor Brandstetter, 2016-06-22 20:14:24]

Description was changed from

==========
Set the generation on peer reflexive candidates when created.

If an actual peer reflexive candidate was created (and not one that
would just be replaced by a different candidate later), we weren't
setting the generation value. This means that new-generation prflx
candidate pairs weren't being prioritized above the cross-generation
pairs, or above relay<->relay pairs.
==========

to

==========
Set the generation on peer reflexive candidates when created.

If an actual peer reflexive candidate was created (and not one that
would just be replaced by a different candidate later), we weren't
setting the generation value. This means that new-generation prflx
candidate pairs weren't being prioritized above the cross-generation
pairs, or above relay<->relay pairs.

R=honghaiz@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/f7c15a915924d5a2c2afb7eea...
==========

[commit-bot: I haz the power, 2016-06-22 20:14:26]

Description was changed from

==========
Set the generation on peer reflexive candidates when created.

If an actual peer reflexive candidate was created (and not one that
would just be replaced by a different candidate later), we weren't
setting the generation value. This means that new-generation prflx
candidate pairs weren't being prioritized above the cross-generation
pairs, or above relay<->relay pairs.

R=honghaiz@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/f7c15a915924d5a2c2afb7eea...
==========

to

==========
Set the generation on peer reflexive candidates when created.

If an actual peer reflexive candidate was created (and not one that
would just be replaced by a different candidate later), we weren't
setting the generation value. This means that new-generation prflx
candidate pairs weren't being prioritized above the cross-generation
pairs, or above relay<->relay pairs.

R=honghaiz@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/f7c15a915924d5a2c2afb7eeaed828728da1f9ec
Cr-Commit-Position: refs/heads/master@{#13259}
==========

[Taylor Brandstetter, 2016-06-22 20:14:26]

Committed patchset #2 (id:20001) manually as
f7c15a915924d5a2c2afb7eeaed828728da1f9ec (presubmit successful).